fix: skip gitops-managed projects in filesystem cleanup (#2266)

[GiulioSavini]

Summary

• cleanupDBProjects was permanently deleting DB records for projects linked via Git-Sync whenever the compose file was missing from disk (e.g. after an SSH/clone failure, or during a sync cycle where files haven't been written yet).
• After removing a Git-Sync link, DeleteSync clears GitOpsManagedBy before the next cleanup run — so even a brief window where the directory is empty caused the record to be deleted with no recovery path.
• Fix: add a guard at the top of the cleanup loop that skips any project with GitOpsManagedBy set, since its lifecycle belongs to the gitops system, not the filesystem scanner.

Closes #2266

Test plan

• Configure a project with Git-Sync enabled
• Stop the git-sync job so the compose file is absent from disk
• Trigger a filesystem scan (or wait for the periodic cleanup)
• Verify the project still appears in the UI (was previously deleted)
• Remove the Git-Sync link; verify the project record persists after the next cleanup pass

🤖 Generated with Claude Code

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

Adds a guard in cleanupDBProjects that skips any project with a non-empty GitOpsManagedBy, preventing the filesystem cleanup loop from permanently deleting gitops-managed projects when their compose files are temporarily absent (e.g. during a sync cycle or after an SSH/clone failure). The fix is minimal and correctly scoped; it aligns with how the same field is guarded in other parts of the service.

Confidence Score: 5/5

Safe to merge — the fix is minimal, targeted, and correct; only a cosmetic style inconsistency remains.

All findings are P2 (style/consistency). The logic itself correctly addresses the described bug and is consistent with the codebase's existing handling of GitOpsManagedBy.

No files require special attention.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: backend/internal/services/project_service.go
Line: 1012

Comment:
**Inconsistent whitespace guard vs. the parallel check**

The existing check for the same field at line 397 uses `strings.TrimSpace(*proj.GitOpsManagedBy) != ""`, but this new guard compares directly against `""`. Since `GitOpsManagedBy` values are always UUIDs in practice this will never differ, but for defensive consistency it's worth aligning the two.

```suggestion
		if p.GitOpsManagedBy != nil && strings.TrimSpace(*p.GitOpsManagedBy) != "" {
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix: skip gitops-managed projects in fil..." | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.

[kmendell]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[greptile-apps]

Inconsistent whitespace guard vs. the parallel check

The existing check for the same field at line 397 uses strings.TrimSpace(*proj.GitOpsManagedBy) != "", but this new guard compares directly against "". Since GitOpsManagedBy values are always UUIDs in practice this will never differ, but for defensive consistency it's worth aligning the two.

Suggested change

	if p.GitOpsManagedBy != nil && *p.GitOpsManagedBy != "" {
	if p.GitOpsManagedBy != nil && strings.TrimSpace(*p.GitOpsManagedBy) != "" {

Prompt To Fix With AI

This is a comment left during a code review.
Path: backend/internal/services/project_service.go
Line: 1012

Comment:
**Inconsistent whitespace guard vs. the parallel check**

The existing check for the same field at line 397 uses `strings.TrimSpace(*proj.GitOpsManagedBy) != ""`, but this new guard compares directly against `""`. Since `GitOpsManagedBy` values are always UUIDs in practice this will never differ, but for defensive consistency it's worth aligning the two.

```suggestion
		if p.GitOpsManagedBy != nil && strings.TrimSpace(*p.GitOpsManagedBy) != "" {
```

How can I resolve this? If you propose a fix, please make it concise.