Skip to content

fix: skip gitops-managed projects in filesystem cleanup (#2266) #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmendell merged 2 commits into from
Apr 12, 2026
Merged

fix: skip gitops-managed projects in filesystem cleanup (#2266) #2354

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb7c94c
fix: skip gitops-managed projects in filesystem cleanup (#2266)
GiulioSavini Apr 12, 2026
214e64a
fix: align whitespace guard with existing pattern per review
GiulioSavini Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions backend/internal/services/project_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,13 @@ func (s *ProjectService) cleanupDBProjects(ctx context.Context, seen map[string]
continue
}

// Skip projects whose lifecycle is owned by the gitops system.
// Their compose files may not exist on disk yet (e.g. during a sync
// or after an SSH/clone failure) and should never be deleted here.
if p.GitOpsManagedBy != nil && *p.GitOpsManagedBy != "" {
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Inconsistent whitespace guard vs. the parallel check

The existing check for the same field at line 397 uses strings.TrimSpace(*proj.GitOpsManagedBy) != "", but this new guard compares directly against "". Since GitOpsManagedBy values are always UUIDs in practice this will never differ, but for defensive consistency it's worth aligning the two.

Suggested change
if p.GitOpsManagedBy != nil && *p.GitOpsManagedBy != "" {
if p.GitOpsManagedBy != nil && strings.TrimSpace(*p.GitOpsManagedBy) != "" {
Prompt To Fix With AI 
This is a comment left during a code review.
Path: backend/internal/services/project_service.go
Line: 1012

Comment:
**Inconsistent whitespace guard vs. the parallel check**

The existing check for the same field at line 397 uses `strings.TrimSpace(*proj.GitOpsManagedBy) != ""`, but this new guard compares directly against `""`. Since `GitOpsManagedBy` values are always UUIDs in practice this will never differ, but for defensive consistency it's worth aligning the two.

```suggestion
		if p.GitOpsManagedBy != nil && strings.TrimSpace(*p.GitOpsManagedBy) != "" {
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Codex

continue
}

validDir, err := projects.IsProjectDirectoryPath(p.Path, followProjectSymlinks)
if err != nil {
if os.IsNotExist(err) {
Expand Down
Loading