Deburring safer-ffi (maintainability improvements)
#245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Lua FFI has a few notable differrences from regular generated C headers: * Custom prelude/epilogue with `ffi.cdef` directive. * Constants defined using `static const` syntax instead of `#define`. * Different comments format using `--` or `[[` instead of `/* */`. * Doesn't support `#include`, `#ifdef` or other macros. Lua FFI described in more details at http://luajit.org/ext_ffi.html Other changes: * Added const generics support for the structs. * Added implementation for array of any const size `N`. * Added `try_as_str` implementation for `str_ref` and `slice_ref<u8>`.
the undocumented names (without period in dotnet 5+) can drop their support when move to double-digit (to avoid potential conflicts) https://learn.microsoft.com/en-us/dotnet/standard/frameworks#supported-target-frameworks
Lua language support tweaks
* Bump MSRV to `1.85.0`
* Start working on `0.2.0` version
* Rust 1.85.0 cleanup
* Do not make `releasable-to-crates-io` GHA step mandatory, until it gets fixed/improved
* `mv {ffi,js}_tests/.cargo/config{,.toml}`
* Nits
* Remove unknown `cfg` warning when targeting js
* Use more recent `nightly` in the `no_std` proper test
This was referenced Mar 24, 2025
Merged
This was referenced Mar 26, 2025
rustfmt some mods which had been skipped
feat(alloc): Add support for `repr_c::Arc<T>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main integration branch to include a bunch of changes to make maintenance of
safer-ffiand contributions to it easier.rustfmtin the codebase #249::syndependency to2.0#253diagnostic::on_unimplemented;macro_rules!hacks;