-
Notifications
You must be signed in to change notification settings - Fork 48
Allow, use, and enforce rustfmt in the codebase
#249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
57f172c to
95685f2
Compare
95685f2 to
b65201a
Compare
Merged
0fd2404 to
1b7d89e
Compare
1b7d89e to
fc4f261
Compare
439391c to
fd9db3c
Compare
acaa8ab to
434f17f
Compare
This reverts commit 434f17f. It wasn't necessary given the usage of a `concurrency-group`
danielhenrymantilla
added a commit
that referenced
this pull request
Jun 24, 2025
Main integration branch to include a bunch of changes to make
maintenance of `safer-ffi` and contributions to it easier.
- Personal feature-set TODO-list, in-order of priority:
- [x] #246
- [x] #248
- [x] #249
- [x] #254
- [x] #251
- [x] #252
- [x] #253
- [x] #259
- [ ] #260
- ❌ **The following ones have not made the cut yet, shall be left for
some follow-up deburring effort**
- [ ] Set-up ergonomic UI/diagnostics tests
- [ ] Use `diagnostic::on_unimplemented`;
- [ ] Clean-up macros, aiming to reduce `macro_rules!` hacks;
- [ ] Revamp module naming;
- Catering to community submissions (with tweaks & adjustments when
necessary):
- [x] #247
- [x] #242
- [x] #250
- Catering to community issues:
- [x] #213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
safer-ffi(maintainability improvements) #245Targets Bump to 2024 edition #248