Skip to content

Conversation

@fenollp
Copy link
Collaborator

@fenollp fenollp commented Dec 5, 2024

No description provided.

@fenollp fenollp linked an issue Dec 5, 2024 that may be closed by this pull request
@fenollp
Copy link
Collaborator Author

fenollp commented Dec 5, 2024

     kin-openapi.git actually-replace-invopop λ go mod tidy && go mod verify
go: finding module for package github.com/oasdiff/yaml3
go: finding module for package github.com/oasdiff/yaml
go: found github.com/oasdiff/yaml in github.com/oasdiff/yaml v0.0.0-20240920191703-3e5a9fb5bdf3
go: found github.com/oasdiff/yaml3 in github.com/oasdiff/yaml3 v0.0.0-20240920135353-c185dc6ea7c6
go: github.com/getkin/kin-openapi/cmd/validate imports
	github.com/oasdiff/yaml: github.com/oasdiff/[email protected]: parsing go.mod:
	module declares its path as: github.com/invopop/yaml
	        but was required as: github.com/oasdiff/yaml
1    kin-openapi.git actually-replace-invopop λ 

@reuvenharrison Could you update your yaml packages's mod path so the above no longer reproduces please?

@ccoVeille
Copy link

The current oasdiff is the fork from the one you replace

The one you replace was already a fork from another one.

The oasdiff README doesn't mention (yet) its purpose and why you decided to create your fork.

So I'm asking here, why such a fork? And why changing here

@fenollp
Copy link
Collaborator Author

fenollp commented Dec 5, 2024

Hi @ccoVeille
Please see @reuvenharrison's past PRs to understand how his fork of yaml packages got in there: https://github.com/getkin/kin-openapi/pulls?q=sort%3Aupdated-desc+is%3Apr+author%3Areuvenharrison+is%3Amerged
Also note that I do not maintain such forks.
As to why the changes in this PR, please see the linked issue: #1036

Feel free to pursue the conversation here if you feel the need to.

@ccoVeille
Copy link

Thank you for the explanations.

It's now clearer

@ccoVeille
Copy link

Maybe the README of oassdiff could be updated to explain that.

Do you want me to open an issue on the oasdiff/yaml repository pointing our discussion?

@reuvenharrison
Copy link
Contributor

I will update the readme to clarify this. Thanks.

@reuvenharrison
Copy link
Contributor

See #1038

@fenollp
Copy link
Collaborator Author

fenollp commented Dec 11, 2024

Fixed in #1038

@fenollp fenollp closed this Dec 11, 2024
@fenollp fenollp deleted the actually-replace-invopop branch December 11, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openapi3: can't build from latest master

3 participants