-
-
Notifications
You must be signed in to change notification settings - Fork 366
fix: Add null-handling for value in profile timeseries #5806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5806 +/- ##
=============================================
+ Coverage 86.620% 86.622% +0.001%
=============================================
Files 423 423
Lines 36400 36405 +5
Branches 17215 17225 +10
=============================================
+ Hits 31530 31535 +5
+ Misses 4823 4822 -1
- Partials 47 48 +1
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
db9572a | 1200.27 ms | 1234.80 ms | 34.53 ms |
1b9991e | 1233.45 ms | 1256.61 ms | 23.17 ms |
9add417 | 1224.33 ms | 1243.06 ms | 18.73 ms |
e3767a1 | 1224.20 ms | 1257.16 ms | 32.96 ms |
51f74d7 | 1236.31 ms | 1247.43 ms | 11.12 ms |
f5d202b | 1237.90 ms | 1259.49 ms | 21.59 ms |
c63e0fe | 1230.58 ms | 1253.94 ms | 23.35 ms |
438caec | 1230.02 ms | 1250.00 ms | 19.98 ms |
d38165b | 1211.41 ms | 1242.49 ms | 31.08 ms |
5bf2b17 | 1213.53 ms | 1238.54 ms | 25.01 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
db9572a | 23.75 KiB | 858.69 KiB | 834.93 KiB |
1b9991e | 23.75 KiB | 908.01 KiB | 884.26 KiB |
9add417 | 23.75 KiB | 908.40 KiB | 884.65 KiB |
e3767a1 | 23.75 KiB | 913.14 KiB | 889.39 KiB |
51f74d7 | 23.74 KiB | 874.08 KiB | 850.34 KiB |
f5d202b | 23.75 KiB | 904.53 KiB | 880.78 KiB |
c63e0fe | 23.74 KiB | 874.08 KiB | 850.33 KiB |
438caec | 23.74 KiB | 913.14 KiB | 889.40 KiB |
d38165b | 23.75 KiB | 855.37 KiB | 831.62 KiB |
5bf2b17 | 23.75 KiB | 913.27 KiB | 889.52 KiB |
Previous results on branch: philprime/strict-nullability-16
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
44fbb9c | 1247.45 ms | 1252.27 ms | 4.82 ms |
1f9d772 | 1240.61 ms | 1264.41 ms | 23.80 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
44fbb9c | 23.75 KiB | 913.39 KiB | 889.64 KiB |
1f9d772 | 23.74 KiB | 913.38 KiB | 889.63 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those null-handling silencing PRs are excellent bug detectors 😄
cursor review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests, LGTM
Co-authored-by: Philipp Hofmann <[email protected]>
@codecov-ai-reviewer test |
On it! Codecov is generating unit tests for this PR. |
…ntry#5806)" This reverts commit 37183fe.
…ntry#5806)" This reverts commit 37183fe.
This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.
Adds silencing of a null-handling warning by ignoring it, because Objective-C dictionaries should be able to handle null.
#skip-changelog