Skip to content

Conversation

philprime
Copy link
Member

This PR is derived from #5572 in an effort to make the large amount of changes easier to review for #5577.

Adds silencing of a null-handling warning by ignoring it, because Objective-C dictionaries should be able to handle null.

#skip-changelog

Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.622%. Comparing base (d88a5e4) to head (aa46cb6).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5806       +/-   ##
=============================================
+ Coverage   86.620%   86.622%   +0.001%     
=============================================
  Files          423       423               
  Lines        36400     36405        +5     
  Branches     17215     17225       +10     
=============================================
+ Hits         31530     31535        +5     
+ Misses        4823      4822        -1     
- Partials        47        48        +1     
Files with missing lines Coverage Δ
Sources/Sentry/SentryProfileTimeseries.m 73.033% <100.000%> (+14.700%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88a5e4...aa46cb6. Read the comment docs.

Copy link
Contributor

github-actions bot commented Aug 5, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.31 ms 1251.68 ms 31.37 ms
Size 23.75 KiB 913.63 KiB 889.88 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
db9572a 1200.27 ms 1234.80 ms 34.53 ms
1b9991e 1233.45 ms 1256.61 ms 23.17 ms
9add417 1224.33 ms 1243.06 ms 18.73 ms
e3767a1 1224.20 ms 1257.16 ms 32.96 ms
51f74d7 1236.31 ms 1247.43 ms 11.12 ms
f5d202b 1237.90 ms 1259.49 ms 21.59 ms
c63e0fe 1230.58 ms 1253.94 ms 23.35 ms
438caec 1230.02 ms 1250.00 ms 19.98 ms
d38165b 1211.41 ms 1242.49 ms 31.08 ms
5bf2b17 1213.53 ms 1238.54 ms 25.01 ms

App size

Revision Plain With Sentry Diff
db9572a 23.75 KiB 858.69 KiB 834.93 KiB
1b9991e 23.75 KiB 908.01 KiB 884.26 KiB
9add417 23.75 KiB 908.40 KiB 884.65 KiB
e3767a1 23.75 KiB 913.14 KiB 889.39 KiB
51f74d7 23.74 KiB 874.08 KiB 850.34 KiB
f5d202b 23.75 KiB 904.53 KiB 880.78 KiB
c63e0fe 23.74 KiB 874.08 KiB 850.33 KiB
438caec 23.74 KiB 913.14 KiB 889.40 KiB
d38165b 23.75 KiB 855.37 KiB 831.62 KiB
5bf2b17 23.75 KiB 913.27 KiB 889.52 KiB

Previous results on branch: philprime/strict-nullability-16

Startup times

Revision Plain With Sentry Diff
44fbb9c 1247.45 ms 1252.27 ms 4.82 ms
1f9d772 1240.61 ms 1264.41 ms 23.80 ms

App size

Revision Plain With Sentry Diff
44fbb9c 23.75 KiB 913.39 KiB 889.64 KiB
1f9d772 23.74 KiB 913.38 KiB 889.63 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those null-handling silencing PRs are excellent bug detectors 😄

@philprime philprime changed the title fix: Add null-handling silencing in slice trace profile GPU data fix: Add null-handling for value in profile timeseries Aug 6, 2025
@philprime
Copy link
Member Author

cursor review

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests, LGTM

@philprime philprime added the Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks. label Aug 7, 2025
@philprime
Copy link
Member Author

@codecov-ai-reviewer test

Copy link

codecov-ai bot commented Aug 7, 2025

On it! Codecov is generating unit tests for this PR.

@philprime philprime merged commit 37183fe into main Aug 7, 2025
135 of 140 checks passed
@philprime philprime deleted the philprime/strict-nullability-16 branch August 7, 2025 13:02
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
philipsawyerdd added a commit to justin-doordash/sentry-cocoa that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Waiting for: CI 🤖 Marks PR as ready-for-merge when CI passes. To be replaced with required checks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants