Skip to content

Conversation

cleptric
Copy link
Member

@cleptric cleptric commented Oct 3, 2025

Once merged, update the Required Status checks to include the newly added Go 1.25 checks. Go 1.22 was already removed to being able to merge this one.

Copy link

linear bot commented Oct 3, 2025

@cleptric cleptric self-assigned this Oct 3, 2025
@cleptric cleptric added the dependencies Pull requests that update a dependency file label Oct 3, 2025
strategy:
matrix:
go: ["1.24", "1.23", "1.22"]
go: ["1.25", "1.24", "1.23"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: CI Matrix Mismatch with Go Versions

The CI matrix adds Go 1.25, which is not yet released, causing workflow setup to fail. This also creates an inconsistency with go.mod files, which are updated only to Go 1.23, potentially leading to compatibility issues.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://go.dev/blog/go1.25, you have to love world knowledge with LLMs...

Copy link

codecov bot commented Oct 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.95%. Comparing base (4763853) to head (f5df5b4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1103      +/-   ##
==========================================
- Coverage   86.98%   86.95%   -0.04%     
==========================================
  Files          55       55              
  Lines        6070     6070              
==========================================
- Hits         5280     5278       -2     
- Misses        645      647       +2     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cleptric cleptric requested a review from giortzisg October 3, 2025 20:19
@cleptric cleptric merged commit 4edee8a into master Oct 6, 2025
18 checks passed
@cleptric cleptric deleted the go-1.25 branch October 6, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants