Skip to content

Run tests on Go 1.25 and remove Go 1.22 #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Run tests on Go 1.25 and remove Go 1.22 #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
${{ runner.os }}-go-${{ matrix.go }}-
- name: Tidy for min version
run: make mod-tidy
if: ${{ matrix.go == '1.22' }}
if: ${{ matrix.go == '1.23' }}
- name: Build
run: make build
- name: Vet
Expand All @@ -62,6 +62,6 @@ jobs:
timeout-minutes: 15
strategy:
matrix:
go: ["1.24", "1.23", "1.22"]
go: ["1.25", "1.24", "1.23"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: CI Matrix Mismatch with Go Versions

The CI matrix adds Go 1.25, which is not yet released, causing workflow setup to fail. This also creates an inconsistency with go.mod files, which are updated only to Go 1.23, potentially leading to compatibility issues.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://go.dev/blog/go1.25, you have to love world knowledge with LLMs...

os: [ubuntu, windows, macos]
fail-fast: false
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ mod-tidy: ## Check go.mod tidiness
set -e ; \
for dir in $(ALL_GO_MOD_DIRS); do \
echo ">>> Running 'go mod tidy' for module: $${dir}"; \
(cd "$${dir}" && go mod tidy -go=1.22 -compat=1.22); \
(cd "$${dir}" && go mod tidy -go=1.23 -compat=1.23); \
done; \
git diff --exit-code;
.PHONY: mod-tidy
Expand Down
2 changes: 1 addition & 1 deletion echo/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/echo

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion fasthttp/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/fasthttp

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion fiber/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/fiber

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion gin/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/gin

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go

go 1.22
go 1.23

require (
github.com/go-errors/errors v1.4.2
Expand Down
2 changes: 1 addition & 1 deletion iris/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/iris

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion logrus/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/logrus

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion negroni/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/negroni

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion otel/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/otel

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion slog/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/slog

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
2 changes: 1 addition & 1 deletion zerolog/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/getsentry/sentry-go/zerolog

go 1.22
go 1.23

replace github.com/getsentry/sentry-go => ../

Expand Down
Loading