test(google-serverless): Migrate to Vitest #15567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rewrite makes the tests less accurate because we are no longer testing against google-gax directly, but this feels like something we should be doing in our integration tests instead. As an alternative we check that we are filling the prototype correctly, and then if we are patching the google-gax stub properly. This also allows us to drop googleapis and google-gax as dev deps.
|
Pushed up a12a493 I'm just going to go with this so we can merge this in. I know it's not ideal, but serverless isn't extremely high priority for us to figure out these problems. We should eventually move this over to use OTEL instrumentation anyway. |
AbhiPrasad
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/integrations/google-cloud-grpc.test.tsis still failing and probably needs simplifying