App Submission: Tunnelsats v3.0.0 #4919
Draft
Annotations
6 errors, 5 warnings, and 2 notices
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5
❌ Linting failed with 5 errors and 5 warnings ❌
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/umbrel-app.yml#L11
The "releaseNotes" field must be empty for new app submissions as it is being displayed to the user only in case of an update.
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/umbrel-app.yml#L0
The submission field must be set to the URL of this pull request: https://github.com/getumbrel/umbrel-apps/pull/4919
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/umbrel-app.yml#L0
The "submission" key is required
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/umbrel-app.yml#L0
The "submitter" key is required
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/docker-compose.yml#L5
Images should be named like "<name>:<version-tag>@<sha256>"
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/umbrel-app.yml#L20
The "icon" and "gallery" fields must be empty for new app submissions as it is being created by the Umbrel team.
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/docker-compose.yml#L14
The volume "/var/run/docker.sock:/var/run/docker.sock:ro" mounts the Docker socket, which can be a security risk. Consider using docker-in-docker instead (see portainer as an example).
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/docker-compose.yml#L14
Volumes should not be mounted directly into the "${APP_DATA_DIR}" directory! Please use a subdirectory like "${APP_DATA_DIR}/data-./data}/../core-lightning/data/lightningd/bitcoin" instead.
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/docker-compose.yml#L14
Volumes should not be mounted directly into the "${APP_DATA_DIR}" directory! Please use a subdirectory like "${APP_DATA_DIR}/data-./data}/../lightning/data/lnd" instead.
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/docker-compose.yml#L14
Volumes should not be mounted directly into the "${APP_DATA_DIR}" directory! Please use a subdirectory like "${APP_DATA_DIR}/data-./data}" instead.
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/docker-compose.yml#L8
The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports.
|
|
Run sharknoon/umbrel-app-linter-action@28d2ca16e3899585a245f1a580cc2361035e23d5:
tunnelsats/docker-compose.yml#L0
The default container user "root" can lead to security vulnerabilities. If you are using the root user, please try to specify a different user (e.g. "1000:1000") in the compose file or try to set the UID/PUID and GID/PGID environment variables to 1000.
|
Loading