Skip to content

App Submission: Tunnelsats v3.0.0 #4919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TrezorHannes wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

App Submission: Tunnelsats v3.0.0 #4919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tunnelsats/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
version: '3.7'
services:
tunnelsats:
build: .
image: tunnelsats/umbrel-app:latest

Check failure on line 5 in tunnelsats/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Invalid image name "tunnelsats/umbrel-app:latest" 

Images should be named like "<name>:<version-tag>@<sha256>"
container_name: tunnelsats
restart: on-failure
network_mode: "host"

Check notice on line 8 in tunnelsats/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Service "tunnelsats" uses host network mode 

The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports.
cap_add:
- NET_ADMIN
- NET_RAW
security_opt:
- apparmor:unconfined
volumes:

Check warning on line 14 in tunnelsats/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Docker socket is mounted in "tunnelsats" 

The volume "/var/run/docker.sock:/var/run/docker.sock:ro" mounts the Docker socket, which can be a security risk. Consider using docker-in-docker instead (see portainer as an example).

Check warning on line 14 in tunnelsats/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Volume "${APP_DATA_DIR:-./data}/../core-lightning/data/lightningd/bitcoin:/lightning-data/cln" 

Volumes should not be mounted directly into the "${APP_DATA_DIR}" directory! Please use a subdirectory like "${APP_DATA_DIR}/data-./data}/../core-lightning/data/lightningd/bitcoin" instead.

Check warning on line 14 in tunnelsats/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Volume "${APP_DATA_DIR:-./data}/../lightning/data/lnd:/lightning-data/lnd" 

Volumes should not be mounted directly into the "${APP_DATA_DIR}" directory! Please use a subdirectory like "${APP_DATA_DIR}/data-./data}/../lightning/data/lnd" instead.

Check warning on line 14 in tunnelsats/docker-compose.yml

View workflow job for this annotation

GitHub Actions / Lint apps

Volume "${APP_DATA_DIR:-./data}:/data" 

Volumes should not be mounted directly into the "${APP_DATA_DIR}" directory! Please use a subdirectory like "${APP_DATA_DIR}/data-./data}" instead.
# Mount the app's persistent storage for configs
- ${APP_DATA_DIR:-./data}:/data
# Try to mount LN config directories to automate config insertion (graceful degradation if missing)
- ${APP_DATA_DIR:-./data}/../lightning/data/lnd:/lightning-data/lnd
- ${APP_DATA_DIR:-./data}/../core-lightning/data/lightningd/bitcoin:/lightning-data/cln
# Required to interrogate container IPs dynamically (Umbrel 1.6+)
- /var/run/docker.sock:/var/run/docker.sock:ro
Binary file added tunnelsats/gallery-1.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
354 changes: 354 additions & 0 deletions tunnelsats/icon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading