-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Ukrainian translations and locale support #6759
Conversation
@@ -26,6 +26,7 @@ const log = std.log.scoped(.i18n); | |||
pub const locales = [_][:0]const u8{ | |||
"de_DE.UTF-8", | |||
"zh_CN.UTF-8", | |||
"uk_UA.UTF-8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend keeping these sorted according to their ASCII ordering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the order does matter. See the doc comment above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why I got tagged for review (I know pretty much nothing about Ukrainian) but at a glance nothing seems particularly wrong. The strings may be a bit too long, though — have you tested your translations within Ghostty and see how much space the strings take up? (It's especially crucial for context menus where one ideally shouldn't have the menu covering half of the screen.)
@pluiedev I'm on macOS, and I heard that translations are not yet available here, so I can't test it. However, I was referring to other terminal apps and to the Ukrainian language in macOS in general - it's okay that some strings may be longer than in English. I also tried to keep them the same length in cases where multiline strings are being used as you can see. |
Do you accept the responsibility to be on the |
I've been working on Ukrainian translation as well. But @danulqua beat me to it : ) If you need more than one person to maintain Ukrainian translation I would be glad to help. |
@danulqua Ukrainian does not have capitalization like here: "Відкрити Конфігурацію". |
@mitchellh Yes, I would be happy to contribute! |
Translations preserve the capitalization from the original text, as you can see; nothing was changed on my end in this context.
I'll update this one, thanks. |
@pluiedev I checked the macOS Terminal app in Ukrainian, and indeed, it also isn't using title case. I just thought that we should preserve the case from the original text. Now I will keep that in mind. I pushed a fix that removes title casing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing feedback. Updated the code owners file and fixed some merge issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some blank translations
Added the Ukrainian
uk_UA
translations.