Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Ukrainian translations and locale support #6759

Merged
merged 14 commits into from
Mar 24, 2025

Conversation

danulqua
Copy link
Contributor

Added the Ukrainian uk_UA translations.

@@ -26,6 +26,7 @@ const log = std.log.scoped(.i18n);
pub const locales = [_][:0]const u8{
"de_DE.UTF-8",
"zh_CN.UTF-8",
"uk_UA.UTF-8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend keeping these sorted according to their ASCII ordering.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the order does matter. See the doc comment above

@danulqua danulqua requested review from jcollie and pluiedev March 16, 2025 21:00
Copy link
Member

@pluiedev pluiedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why I got tagged for review (I know pretty much nothing about Ukrainian) but at a glance nothing seems particularly wrong. The strings may be a bit too long, though — have you tested your translations within Ghostty and see how much space the strings take up? (It's especially crucial for context menus where one ideally shouldn't have the menu covering half of the screen.)

@pluiedev pluiedev added the translations Translations of the Ghostty app label Mar 16, 2025
@danulqua
Copy link
Contributor Author

@pluiedev I'm on macOS, and I heard that translations are not yet available here, so I can't test it. However, I was referring to other terminal apps and to the Ukrainian language in macOS in general - it's okay that some strings may be longer than in English. I also tried to keep them the same length in cases where multiline strings are being used as you can see.

@mitchellh
Copy link
Contributor

Do you accept the responsibility to be on the uk_UA localization team and get pinged for future string changes?

@gordonbondon
Copy link

I've been working on Ukrainian translation as well. But @danulqua beat me to it : )

If you need more than one person to maintain Ukrainian translation I would be glad to help.

@varyform
Copy link

@danulqua Ukrainian does not have capitalization like here: "Відкрити Конфігурацію".
That's probably ok, bit it's not consistent with "Перезавантажено конфігурацію" (which I would also change to "Конфігурацію перезавантажено")

@danulqua
Copy link
Contributor Author

@mitchellh Yes, I would be happy to contribute!

@danulqua
Copy link
Contributor Author

danulqua commented Mar 18, 2025

@varyform

Ukrainian does not have capitalization like here: "Відкрити Конфігурацію".

Translations preserve the capitalization from the original text, as you can see; nothing was changed on my end in this context.

"Перезавантажено конфігурацію" (which I would also change to "Конфігурацію перезавантажено").

I'll update this one, thanks.

@pluiedev
Copy link
Member

image

Just FYI, GNOME Console doesn't do title case either and we should follow what it does

@danulqua
Copy link
Contributor Author

@pluiedev I checked the macOS Terminal app in Ukrainian, and indeed, it also isn't using title case. I just thought that we should preserve the case from the original text. Now I will keep that in mind.

I pushed a fix that removes title casing.

Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing feedback. Updated the code owners file and fixed some merge issues.

@mitchellh mitchellh enabled auto-merge March 19, 2025 15:53
@mitchellh mitchellh disabled auto-merge March 19, 2025 15:53
@mitchellh mitchellh requested review from a team as code owners March 19, 2025 15:54
Copy link
Contributor

@mitchellh mitchellh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some blank translations

@mitchellh mitchellh merged commit 150b7bd into ghostty-org:main Mar 24, 2025
9 checks passed
@github-actions github-actions bot added this to the 1.2.0 milestone Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations of the Ghostty app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants