-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pl_PL translations #6771
pl_PL translations #6771
Conversation
Do you accept to be on the pl_PL localization team @Secrus? |
@mitchellh sure |
fe1fa9b
to
86f6160
Compare
I'd like to be part of the |
94da957
to
992b26c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translations look good to me (just one nit) 👍
I think the locales
ordering might need to be adjusted, since we prefer "most common locales first" and I imagine there are more Polish than Norwegian users (and most definitely more speakers).
(btw Chinese being listed after Norwegian feels sus)
Lines 11 to 14 in 992b26c
So it's unlikely to cause problems, but as noted below it should probably be reordered sometime. |
I don't think the reordering of the locales belongs in this PR. It's a valid issue, IMHO, but it should be addressed somewhere else. |
Same. (I wasn't suggesting that it should be done here in case it wasn't clear.) |
1deb46b
to
788f394
Compare
Co-authored-by: chupson <[email protected]> Co-authored-by: trag1c <[email protected]>
e698f6f
to
bf17920
Compare
The initial take on the
pl_PL
translation.