Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pl_PL translations #6771

Merged
merged 1 commit into from
Mar 24, 2025
Merged

pl_PL translations #6771

merged 1 commit into from
Mar 24, 2025

Conversation

Secrus
Copy link
Contributor

@Secrus Secrus commented Mar 17, 2025

The initial take on the pl_PL translation.

@mitchellh
Copy link
Contributor

Do you accept to be on the pl_PL localization team @Secrus?

@Secrus
Copy link
Contributor Author

Secrus commented Mar 19, 2025

@mitchellh sure

@Secrus Secrus force-pushed the pl_PL-translation branch from fe1fa9b to 86f6160 Compare March 19, 2025 09:44
@jcollie jcollie added the translations Translations of the Ghostty app label Mar 19, 2025
@trag1c
Copy link
Member

trag1c commented Mar 20, 2025

I'd like to be part of the pl_PL team as well 🙂

@Secrus Secrus force-pushed the pl_PL-translation branch from 94da957 to 992b26c Compare March 23, 2025 12:46
@Secrus Secrus requested review from trag1c and pluiedev March 23, 2025 12:52
@Secrus Secrus marked this pull request as ready for review March 23, 2025 12:52
@Secrus Secrus changed the title [WIP] pl_PL translations pl_PL translations Mar 23, 2025
Copy link
Member

@trag1c trag1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translations look good to me (just one nit) 👍

I think the locales ordering might need to be adjusted, since we prefer "most common locales first" and I imagine there are more Polish than Norwegian users (and most definitely more speakers).
(btw Chinese being listed after Norwegian feels sus)

@00-kat
Copy link
Contributor

00-kat commented Mar 24, 2025

(btw Chinese being listed after Norwegian feels sus)

ghostty/src/os/i18n.zig

Lines 11 to 14 in 992b26c

/// The order also matters. For incomplete locale information (i.e. only
/// a language code available), the first match is used. For example, if
/// we know the user requested `zh` but has no script code, then we'd pick
/// the first locale that matches `zh`.

So it's unlikely to cause problems, but as noted below it should probably be reordered sometime.

@Secrus
Copy link
Contributor Author

Secrus commented Mar 24, 2025

I don't think the reordering of the locales belongs in this PR. It's a valid issue, IMHO, but it should be addressed somewhere else.

@00-kat
Copy link
Contributor

00-kat commented Mar 24, 2025

I don't think the reordering of the locales belongs in this PR. It's a valid issue, IMHO

Same. (I wasn't suggesting that it should be done here in case it wasn't clear.)

@Secrus Secrus force-pushed the pl_PL-translation branch 2 times, most recently from 1deb46b to 788f394 Compare March 24, 2025 11:35
Co-authored-by: chupson <[email protected]>
Co-authored-by: trag1c <[email protected]>
@mitchellh mitchellh enabled auto-merge March 24, 2025 17:41
@mitchellh mitchellh disabled auto-merge March 24, 2025 17:43
@mitchellh mitchellh merged commit 5d9bee9 into ghostty-org:main Mar 24, 2025
9 checks passed
@github-actions github-actions bot added this to the 1.2.0 milestone Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations of the Ghostty app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants