-
Notifications
You must be signed in to change notification settings - Fork 787
i18n: add Korean translations #6963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add your locale to this structure please:
Line 26 in 1067cd3
pub const locales = [_][:0]const u8{ |
po/ko_KR.UTF-8.po
Outdated
#: src/apprt/gtk/Window.zig:295 | ||
msgid "" | ||
"⚠️ 디버그 빌드를 실행 중입니다! 성능이 저하될 수 있습니다." | ||
msgstr "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing translation, I assume you forgot?
Apologies, not sure how I missed those two. Fixed them now though. |
(Your commit message is wrong by the way—it's I one eight N not I L eight N.) |
Banning myself from committing things when sleep deprived from now on... |
We now have the automation in place to request review properly and I'd like to move forward with merging these. Thank you and sorry for the wait. @RubenRME do you volunteer to be on the localization team for this language to be pinged on string changes? Would love if there was one other we could find too. |
@mitchellh wouldn't mind for sure! But definitely need someone to double check my Korean. |
Native Korean speaker here, there's some parts I'd love to make comments on but not sure how to suggest improvements. Should I open a PR against your fork? @RubenRME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native Korean, Bi-lingual International student. Love Ghostty, very eager and happy to help in any way to help reach the Korean audience.
@mitchellh if there's still a spot to be pinged for string changes I would love to help out.
Took a look at existing translations, changed to more commonly used wording. If a Korean developer could take a look at it, that would be amazing.
#: src/apprt/gtk/ui/1.0/menu-surface-context_menu.blp:97 | ||
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:95 | ||
msgid "Reload Configuration" | ||
msgstr "설정을 다시 로드하기" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
설정을 다시 '로드' < 외래어, 부 자연스러움 < 가져오기, 불러오기 선호
msgstr "설정을 다시 로드하기" | |
msgstr "설정 값 다시 불러오기" |
#: src/apprt/gtk/Window.zig:295 | ||
msgid "" | ||
"⚠️ You're running a debug build of Ghostty! Performance will be degraded." | ||
msgstr "⚠️ 디버그 빌드를 실행 중입니다! 성능이 저하될 수 있습니다." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
성능이 저하'될' 수 -> 저하됩니다 (might,could be -> will be)
msgstr "⚠️ 디버그 빌드를 실행 중입니다! 성능이 저하될 수 있습니다." | |
msgstr "⚠️ 디버그 빌드 실행 중! 성능이 저하됩니다." |
msgid "" | ||
"One or more configuration errors were found. Please review the errors below, " | ||
"and either reload your configuration or ignore these errors." | ||
msgstr "하나 이상의 설정 오류가 발견되었습니다. 아래 오류를 확인한 후 설정을 다시 로드하거나 무시하세요." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ambiguous. 오류를 vs 오류(를)들을, since original text is error's', however not sure if using (를) in the replacement would be suitable.
msgstr "하나 이상의 설정 오류가 발견되었습니다. 아래 오류를 확인한 후 설정을 다시 로드하거나 무시하세요." | |
msgstr "설정에 하나 이상의 문제가 발견되었습니다. 아래 오류(를)들을 확인한 후 설정을 다시 불러오거나 무시하세요." |
|
||
#: src/apprt/gtk/ui/1.5/prompt-title-dialog.blp:6 | ||
msgid "Leave blank to restore the default title." | ||
msgstr "기본 제목으로 복원하려면 비워 두세요." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tells the user what is going to happen as a consequence of an action, rather than telling a user how to achieve the default state.
msgstr "기본 제목으로 복원하려면 비워 두세요." | |
msgstr "제목란을 비워 두면 기본값으로 복원됩니다." |
|
||
#: src/apprt/gtk/inspector.zig:144 | ||
msgid "Ghostty: Terminal Inspector" | ||
msgstr "Ghostty: 터미널 인스펙터" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인스펙터 -> 외래어 (loanword - line 148)
msgstr "Ghostty: 터미널 인스펙터" | |
msgstr "Ghostty: 터미널 조사 도구" |
|
||
#: src/apprt/gtk/ui/1.0/menu-window-titlebar_menu.blp:85 | ||
msgid "Terminal Inspector" | ||
msgstr "터미널 인스펙터" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인스펙터 -> 외래어, not sure how loanwords are perceived since Korean developers in Pangyo is known for their "dialect" for mixing loanwords and English words within Korean sentences.
msgstr "터미널 인스펙터" | |
msgstr "터미널 조사 도구" |
|
||
#: src/apprt/gtk/Window.zig:725 | ||
msgid "Reloaded the configuration" | ||
msgstr "구성을 다시 로드했습니다" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
구성 -> 설정. 자연스러음 (favoured more commonly used word for settings)
msgstr "구성을 다시 로드했습니다" | |
msgstr "설정값을 다시 불러왔습니다" |
This pull request adds Korean translations.
I do want to add that while I do speak Korean I am not a native speaker. I've done my best to provide translations as natural as possible, but I'd love it if a native speaker could improve it before merging.