Skip to content

Rebase to main fork#1

Open
dicara wants to merge 275 commits intomasterfrom
rebase-to-main-fork
Open

Rebase to main fork#1
dicara wants to merge 275 commits intomasterfrom
rebase-to-main-fork

Conversation

@dicara
Copy link

@dicara dicara commented Jan 18, 2019

No description provided.

jrobinso and others added 30 commits September 5, 2018 10:26
implement drag-scroll for tracks
Lock mouse drag to horizontal or vertical,  not both.
* Upgrade dependencies to work with latest PhantomJS

Prebuilt binaries for PhantomJS 1.9 fail on current macOS, High Sierra.  PhantomJS is needed to run tests but is no longer maintained.  This upgrades QUnit dependencies to a version that runs PhantomJS 2.1, which has prebuilt binaries that work on High Sierra.  It is a stopgap solution to enable continuous integration.  Migrating from PhantomJS to headless Chrome would be a better long-term solution, but that is a larger task.

* Begin transition of tests to headless Chrome

Turns out the tests only run in a GUI via QUnit, not CLI via PhantomJS.  So begin the process to get tests running via CLI.  This is a prerequisite for continuous integration.

* Provide easily usable ES6 export, improve package metadata

This enables including igv.js via ES6 import, while retaining support for AMD require and plain script tags, as discussed in igvteam#701.  It adds 'scripts' and 'files' properties to package.json to build igv.js artifacts before publishing to NPM, and to strip other files from the package.  It also puts metadata previously only visible in the published NPM package into source control, to be more open source and in line with mainstream JS conventions.

* Use prepack NPM event; enables previewing via npm pack

* Update QUnit syntax in bigWig test, qunitPage in Grunt task

* Create .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Update .travis.yml

* Try a 'noSandbox' option

* Try sudo per 2017-06 Google tutorial

* Try running headlessly

* Set up local web server for CI

* Ignore VS Code settings

* Update .travis.yml

* Remove extraneous 'noSandbox' option

* Update QUnit syntax for BAM and BED tests

* Update QUnit syntax in BAM index, AED, and BED graph tests

* Disable block gzipped BED test for now due to false positive

* Update QUnit syntax in remaining test modules

* Disable runBrowserTests for now due to consistent failure

* Add Travis CI badge

* Refine test call to 'grunt test'; remove debug code

* Add conventional 'npm test' alias

* Rearrange deps to reflect dev-only nature; fix insecure deps

* Remove debug, add comment

* Remove more debug code
…alse settings. May or may not be safe to support this otherwise.
jrobinso and others added 29 commits January 11, 2019 14:28
* TrackGearPopover

* git ignoring

* test

* trackGearPopover.

* track gear check mark repair

* css ing

* track gear menu looking good.

* clean up icon markup

* discard dead code

* icon markup cleanup

* user feedback widget

* edits

* apparently, i element is a better svg container then div.

* icon ing

* git ignoring

* icon css cleanup
* Chr aliasing not accounted for
* Add check for mate alignment before accessing
* alert dialog layout fixes

* alerting
* webpack now used to bundle
* async/await supported
* css issues

* css issues
@dicara
Copy link
Author

dicara commented Jan 18, 2019

Got the following feedback from Jim Robinson when I accidentally opened this PR against the main repo master:

I am considering putting the dist artifacts into the repository when I can figure out an automated way to keep them up-to-date. This would be a convenience for npm installing from the repo. Also, I am transitioning slowly to webpack, so the ES5 conversion is now done via webpack (babel, but run from webpack), thus that step is not done in the grunt file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants