fix: remove unused exported interfaces from services and pid-tracker#2715
fix: remove unused exported interfaces from services and pid-tracker#2715
Conversation
- Remove export from NetTcpEntry in src/pid-tracker.ts (internal only) - Remove export from AgentServiceParams, IptablesInitServiceParams in src/services/agent-service.ts - Remove export from AgentVolumesParams in src/services/agent-volumes.ts - Remove export from AgentEnvironmentParams in src/services/agent-environment.ts - Remove re-exports of *Params types from agent-service barrel These interfaces are only used within their own modules and were unnecessarily polluting the public API surface. Closes #2694, closes #2695 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
There was a problem hiding this comment.
Pull request overview
This pull request reduces the public TypeScript API surface by removing exports for several interfaces that are only used internally within their defining modules, aligning with the export-audit issues (#2694, #2695).
Changes:
- Make
NetTcpEntry(pid tracker) and several*Paramsinterfaces (agent services) module-internal by removingexport. - Stop re-exporting
AgentEnvironmentParams/AgentVolumesParamsfromsrc/services/agent-service.ts, while keeping function re-exports for compatibility.
Show a summary per file
| File | Description |
|---|---|
| src/services/agent-volumes.ts | Makes AgentVolumesParams internal while keeping buildAgentVolumes exported. |
| src/services/agent-service.ts | Removes exported param interfaces and drops type re-exports; retains function re-exports. |
| src/services/agent-environment.ts | Makes AgentEnvironmentParams internal while keeping buildAgentEnvironment exported. |
| src/pid-tracker.ts | Makes NetTcpEntry internal while keeping parsing/lookup functions exported. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 0
🔬 Smoke Test Results
PR: fix: remove unused exported interfaces from services and pid-tracker Overall: PASS ✅
|
Smoke Test Results✅ GitHub API: Retrieved last 2 merged PRs
✅ Playwright: github.com page title verified PASS
|
🔥 Smoke Test: Copilot BYOK Offline Mode
Running in BYOK offline mode ( Overall: PARTIAL — BYOK inference and MCP confirmed working; pre-step template outputs were not interpolated. PR: "fix: remove unused exported interfaces from services and pid-tracker" by @lpcox, reviewers:
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
fix(api-proxy): fetch models from BYOK custom providers and fix models_url in reflect Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Chroot Smoke Test Results
Overall: ❌ Not all tests passed — Python and Node.js versions differ between host and chroot.
|
Smoke Test Results — PR #2715
Overall: FAIL —
|
Summary
Removes 5 unnecessarily exported interfaces that were only used internally within their own modules.
Changes
src/pid-tracker.ts:NetTcpEntry→ unexported (used only byparseNetTcpandfindInodeForPortinternally)src/services/agent-service.ts:AgentServiceParams,IptablesInitServiceParams→ unexportedsrc/services/agent-volumes.ts:AgentVolumesParams→ unexportedsrc/services/agent-environment.ts:AgentEnvironmentParams→ unexported*Paramstype re-exports from the agent-service barrelVerification
npm run build✅Closes #2694, closes #2695