Preserve setup-ruby PATH precedence inside AWF by Copilot · Pull Request #58311 · github/gh-aw

Copilot · 2026-09-03T21:31:35Z

GetNpmBinPathSetup prepended every cached runtime bin directory, allowing an older cached Ruby to override the version selected by ruby/setup-ruby.

PATH ordering
- Append discovered tool-cache directories after the existing host PATH.
- Retain explicit GOROOT/bin and ERLANG_HOME/bin precedence.
- Avoid introducing an empty PATH entry when no cached bins exist.
Regression coverage
- Verify the selected Ruby remains authoritative when another version is cached.
- Verify cache-only npm binaries remain discoverable.
- Update generated command snapshots.

Fixes GetNpmBinPathSetup overrides the Ruby version selected by ruby/setup-ruby #57950

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

🔵 Needs a closer look

The Ruby regression test must place the selected Ruby outside the tool-cache directory to verify PATH precedence correctly.

Pull request overview

Preserves setup-selected runtime PATH precedence while keeping cached npm binaries discoverable.

Changes:

Appends cached tool binaries after the existing PATH.
Retains Go/Erlang precedence.
Updates regression coverage, snapshots, and AWF workflow locks.

File summaries

File	Description
`pkg/workflow/testdata/TestWasmGolden_CompileFixtures/with-imports.golden`	Updates generated command snapshot.
`pkg/workflow/testdata/TestWasmGolden_CompileFixtures/smoke-copilot.golden`	Updates generated command snapshot.
`pkg/workflow/testdata/TestWasmGolden_CompileFixtures/playwright-cli-mode.golden`	Updates generated command snapshot.
`pkg/workflow/testdata/TestWasmGolden_CompileFixtures/basic-copilot.golden`	Updates generated command snapshot.
`pkg/workflow/testdata/TestWasmGolden_AllEngines/pi.golden`	Updates Pi command snapshot.
`pkg/workflow/testdata/TestWasmGolden_AllEngines/gemini.golden`	Updates Gemini command snapshot.
`pkg/workflow/testdata/TestWasmGolden_AllEngines/copilot.golden`	Updates Copilot command snapshot.
`pkg/workflow/testdata/TestWasmGolden_AllEngines/codex.golden`	Updates Codex command snapshot.
`pkg/workflow/testdata/TestWasmGolden_AllEngines/claude.golden`	Updates Claude command snapshot.
`pkg/workflow/nodejs.go`	Changes cached-bin PATH ordering.
`pkg/workflow/engine_helpers_test.go`	Adds Ruby/npm coverage, but the Ruby test’s selected binary is inside the tool cache, so it does not catch the prior regression.
`.github/workflows/smoke-ci.lock.yml`	Refreshes generated AWF pins.
`.github/workflows/notion-issue-summary.lock.yml`	Refreshes generated AWF pins.
`.github/workflows/hippo-embed.lock.yml`	Refreshes generated AWF pins.
`.github/workflows/firewall.lock.yml`	Refreshes generated AWF pins.
`.github/workflows/example-permissions-warning.lock.yml`	Refreshes generated AWF pins.
`.github/workflows/daily-arxiv-researcher.lock.yml`	Refreshes AWF pins and generated configuration.
`.github/workflows/codex-github-remote-mcp-test.lock.yml`	Refreshes generated AWF pins.

Review details

Files reviewed: 19/308 changed files
Comments generated: 0
Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-09-03T22:31:46Z

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

No ADR enforcement needed: PR does not have the 'implementation' label and has ≤100 new lines of code in business logic directories.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-09-03T22:32:04Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

github.com
proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"
    - "proxy.golang.org"

See Network Configuration for more information.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-09-03T22:32:14Z

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch PR file list

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-09-03T22:32:15Z

❌ Ponytail Reviewer failed. Please review the logs for details.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

ab.chatgpt.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "ab.chatgpt.com"

See Network Configuration for more information.

Generated by Ponytail Reviewer for #58311

github-actions · 2026-09-03T22:32:17Z

✅ PR Code Quality Reviewer completed the code quality review.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

api.github.com
github.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "github.com"

See Network Configuration for more information.

🔎 Code quality review by PR Code Quality Reviewer

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /tdd to this focused bug fix. The change correctly diagnoses the root cause (prepending cached toolcache bins was shadowing the version ruby/setup-ruby already put earlier on PATH) and switches to appending discovered bins after the existing PATH, which generically preserves precedence for any tool already resolved via actions/setup-*. GOROOT/ERLANG_HOME are explicitly re-prepended since those tools aren't already on PATH before this runs.

📋 Key Themes & Highlights

Key Themes

Root cause vs. symptom: The fix addresses the underlying ordering bug (append instead of prepend) rather than special-casing Ruby, so it should also protect any other setup-* action relying on PATH precedence — nice generalization.
Regression coverage: TestGetNpmBinPathSetup_PreservesSelectedRuby reproduces the exact shadowing scenario (a newer selected Ruby vs. an older cached one) and asserts both the correct ruby --version and that cache-only npm-agent binaries remain discoverable — solid, specific regression test per /tdd.
Existing GOROOT/ERLANG_HOME tests still pass conceptually: the re-prepend order (after find, still forced regardless of append/prepend change) is preserved and covered.
Bulk of the diff is auto-generated .lock.yml snapshot regeneration from make recompile, which is expected and out of scope for manual review.

Positive Highlights

✅ Clear code comments explaining why PATH is appended vs. prepended, and why GOROOT/ERLANG_HOME need explicit re-prepending.
✅ Regression test directly encodes the reported bug (#57950) as an executable assertion instead of just describing it in the PR body.
✅ No unrelated behavior changes bundled into the fix.

No blocking issues found — this is a clean, well-tested, narrowly-scoped fix.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

github.com
proxy.golang.org

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"
    - "proxy.golang.org"

See Network Configuration for more information.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 45.8 AIC · ⌖ 14.7 AIC · ⊞ 10.3K
_{Comment /matt to run again}

github-actions · 2026-09-03T22:38:51Z

Comment Memory

reviewed_at: 2026-09-03T22:33:48Z
review_event: COMMENT
top_themes:
  - path-ordering fix is scoped and regression-covered
  - no additional blocking correctness issues found in reviewed changes
files_reviewed:
  - pkg/workflow/nodejs.go
  - pkg/workflow/engine_helpers_test.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

api.github.com
github.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "github.com"

See Network Configuration for more information.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 52 AIC · ⌖ 7.31 AIC · ⊞ 23.5K · ◷
_{Comment /review to run again}

github-actions

No blocking correctness, performance, or maintainability regressions stood up in the reviewed PATH-ordering change.

### Notes

I checked the runtime PATH mutation and the new regression coverage around Ruby precedence and cache-only npm binaries. The change appends tool-cache bins behind the existing PATH while still re-prepending GOROOT and ERLANG_HOME, which matches the intended fix without obviously breaking the existing engine command chaining behavior.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

api.github.com
github.com

[!TIP]
api.github.com is blocked because GitHub API access uses the built-in GitHub tools by default. Instead of adding api.github.com to network.allowed, use tools.github.mode: gh-proxy for direct pre-authenticated GitHub CLI access without requiring network access to api.github.com:

tools:
  github:
    mode: gh-proxy

See GitHub Tools for more information on gh-proxy mode.

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "api.github.com"
    - "github.com"

See Network Configuration for more information.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt54 · 52 AIC · ⌖ 7.31 AIC · ⊞ 23.5K
_{Comment /review to run again}

pelikhan · 2026-09-03T23:15:54Z

@copilot run pr-finisher skill

… tool cache Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

gh-aw-bot · 2026-09-03T23:37:32Z

@copilot Please take the next forward-progress pass on this PR.

There is still unresolved review feedback from copilot-pull-request-reviewer saying the Ruby regression test does not prove PATH precedence because the selected Ruby is still inside the tool cache.
Please adjust the regression coverage so it reproduces the original precedence bug with the selected Ruby outside the tool-cache path, refresh the branch if needed, and then run the pr-finisher skill.
When you reply, summarize the concrete test setup change and whether any maintainer-facing blocker remains.

Review context:

copilot-pull-request-reviewer: Preserve setup-ruby PATH precedence inside AWF #58311

Generated by 👨🍳 PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 32.7 AIC · ⌖ 9.85 AIC · ⊞ 9.2K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-03T23:59:02Z

@copilot run pr-finisher skill

Ran the PR-finisher pass. The Ruby regression setup is corrected in aaef03e, and the targeted regression tests pass. No maintainer-facing code blocker remains; CI needs a maintainer-triggered rerun after the agent push.

@copilot Please take the next forward-progress pass on this PR.

There is still unresolved review feedback from copilot-pull-request-reviewer saying the Ruby regression test does not prove PATH pr...

Updated in aaef03e: the selected Ruby now lives in a separate temporary directory outside RUNNER_TOOL_CACHE, while an older cached Ruby remains under the cache. The regression test passes and also verifies cache-only npm binaries remain discoverable. No maintainer-facing blocker remains in the code; CI will need a maintainer-triggered rerun after the push.

pelikhan · 2026-09-04T00:05:36Z

/smoke-copilot

github-actions · 2026-09-04T00:06:19Z

📰 BREAKING: Smoke Copilot is now investigating this issue comment. Sources say the story is developing...

pelikhan · 2026-09-04T00:15:30Z

@copilot fix https://github.com/github/gh-aw/actions/runs/33820307532/job/100861749959?pr=58311

github-actions · 2026-09-04T00:18:35Z

Smoke Test Summary

PR: Preserve setup-ruby PATH precedence inside AWF (#58311)

1-16: ✅ except #3 (Serena find_symbol ❌ - lang server init error)

Overall status: FAIL

Author: @copilot-swe-agent — Assignees: @pelikhan, @Copilot

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
www.google.com
www.gstatic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "www.google.com"
    - "www.gstatic.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · copilot · auto · 37.5 AIC · ⌖ 2.61 AIC · ⊞ 10K · ◷
_{Comment /smoke-copilot to run again}
_{Add label smoke to run again}

github-actions · 2026-09-04T00:18:36Z

Comment Memory

Code compiles at dawn
Sub-agents whisper their tests
Green checks light the sky

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
www.google.com
www.gstatic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "www.google.com"
    - "www.gstatic.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · copilot · auto · 37.5 AIC · ⌖ 2.61 AIC · ⊞ 10K · ◷
_{Comment /smoke-copilot to run again}
_{Add label smoke to run again}

github-actions

Automated smoke test review: inline comment added, no blocking issues found.

Warning

Firewall blocked 6 domains

The following domains were blocked by the firewall during workflow execution:

accounts.google.com
android.clients.google.com
clients2.google.com
contentautofill.googleapis.com
www.google.com
www.gstatic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "contentautofill.googleapis.com"
    - "www.google.com"
    - "www.gstatic.com"

See Network Configuration for more information.

📰 BREAKING: Report filed by Smoke Copilot · copilot · auto · 37.5 AIC · ⌖ 2.61 AIC · ⊞ 10K
_{Comment /smoke-copilot to run again}
_{Add label smoke to run again}

Comments that could not be inline-anchored

.github/workflows/ab-testing-advisor.lock.yml:1

Smoke test: inline review comment #1 (automated).

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-04T00:36:16Z

@copilot fix https://github.com/github/gh-aw/actions/runs/33820307532/job/100861749959?pr=58311

Fixed in ea98ca2. The failing Dependabot manifest test now prepends a local npm stub that exits immediately, deterministically exercising the non-strict npm failure path instead of hanging on network access. The targeted test passes; no maintainer-facing code blocker remains.

github-actions · 2026-09-04T06:27:06Z

🎉 This pull request is included in a new release.

Release: v0.88.4

Initial plan

ee4acca

Copilot AI assigned Copilot and pelikhan Sep 3, 2026

Copilot started work on behalf of pelikhan September 3, 2026 21:31 View session

Copilot AI linked an issue Sep 3, 2026 that may be closed by this pull request

GetNpmBinPathSetup overrides the Ruby version selected by ruby/setup-ruby #57950

Closed

Copilot AI and others added 3 commits September 3, 2026 21:40

Preserve runtime PATH ordering

ddbe4c6

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Update PATH regression snapshots

2c494d9

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Apply remaining changes

649e0c0

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix GetNpmBinPathSetup overriding Ruby version~~ Preserve setup-ruby PATH precedence inside AWF Sep 3, 2026

Copilot finished work on behalf of pelikhan September 3, 2026 21:45

Copilot AI requested a review from pelikhan September 3, 2026 21:45

pelikhan marked this pull request as ready for review September 3, 2026 21:48

Copilot AI balanced review requested due to automatic review settings September 3, 2026 21:48

Copilot started reviewing on behalf of pelikhan September 3, 2026 21:48 View session

Copilot AI reviewed Sep 3, 2026

View reviewed changes

pelikhan added the awf label Sep 3, 2026

github-actions Bot mentioned this pull request Sep 3, 2026

[pr-sous-chef] PR Sous Chef run report #58057

Closed

github-actions Bot approved these changes Sep 3, 2026

View reviewed changes

github-actions Bot reviewed Sep 3, 2026

View reviewed changes

github-actions Bot added the needs-review label Sep 3, 2026

Merge branch 'main' into copilot/fix-getnpm-bin-path-setup

9d725d5

Copilot started work on behalf of pelikhan September 3, 2026 23:16 View session

Adjust Ruby precedence regression test to place selected Ruby outside…

aaef03e

… tool cache Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot started work on behalf of pelikhan September 3, 2026 23:26 View session

Copilot finished work on behalf of pelikhan September 3, 2026 23:27

Merge main into copilot/fix-getnpm-bin-path-setup

b25ff8e

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 3, 2026 23:47

Copilot started work on behalf of gh-aw-bot September 3, 2026 23:47 View session

Copilot finished work on behalf of gh-aw-bot September 3, 2026 23:59

Copilot AI requested a review from gh-aw-bot September 3, 2026 23:59

Merge branch 'main' into copilot/fix-getnpm-bin-path-setup

2334684

Copilot started work on behalf of pelikhan September 4, 2026 00:15 View session

github-actions Bot reviewed Sep 4, 2026

View reviewed changes

Make Dependabot manifest test deterministic

ea98ca2

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 4, 2026 00:36

Merge branch 'main' into copilot/fix-getnpm-bin-path-setup

439849b

github-actions Bot mentioned this pull request Sep 4, 2026

[pr-sous-chef] pr-sous-chef run report #58334

Closed

pelikhan merged commit 76182db into main Sep 4, 2026
32 checks passed

pelikhan deleted the copilot/fix-getnpm-bin-path-setup branch September 4, 2026 02:17

ilja mentioned this pull request Sep 4, 2026

docker-sudo-iptables loses setup-ruby PATH before AWF #58458

Closed

Copilot AI mentioned this pull request Sep 4, 2026

Preserve setup-action PATH across privileged AWF startup #58625

Merged

github-actions Bot mentioned this pull request Sep 5, 2026

Smoke Test: MAI-Code-1-Flash - 33931689927 #58644

Closed

Uh oh!

Conversation

Copilot AI commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

github-actions Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Key Themes

Positive Highlights

Uh oh!

github-actions Bot commented Sep 3, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

pelikhan commented Sep 3, 2026

Uh oh!

gh-aw-bot commented Sep 3, 2026

Uh oh!

Copilot AI commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Smoke Test Summary

Uh oh!

github-actions Bot commented Sep 4, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Comments that could not be inline-anchored

Uh oh!

Copilot AI commented Sep 4, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Sep 3, 2026 •

edited

Loading

github-actions Bot commented Sep 3, 2026 •

edited

Loading

github-actions Bot commented Sep 3, 2026 •

edited

Loading

github-actions Bot commented Sep 3, 2026 •

edited

Loading

github-actions Bot commented Sep 3, 2026 •

edited

Loading

github-actions Bot commented Sep 3, 2026 •

edited

Loading

Copilot AI commented Sep 3, 2026 •

edited

Loading

github-actions Bot commented Sep 4, 2026 •

edited

Loading