-
Notifications
You must be signed in to change notification settings - Fork 83.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Unreal Engine plugin binaries on subfolders #3858
base: main
Are you sure you want to change the base?
Conversation
I'm participating in hacktoberfest, so if you can add the |
Unfortunately, we could not make this an Hacktoberfest contribution. Can you clarify this is an issue happening to other UE5/Rider users? |
Hi Yes, other users must also be encountering this. The original ignore rule is, for example, Plugins//Binaries/. The single * between Plugins and Binaries only contemplates one level of subfolders. The issue was that the Rider plugin doesn't output its binaries directly to Plugins/Rider/Binaries/, like the original rule assumed. It had the binaries on a deeper subfolder, Plugins/Developer/RiderLink/Binaries/ which was not being git ignored So I changed the rule to ignore any Intermediate/ and Binaries/ folder, doesn't matter it's depth in the folder hierarchy. For example, these are the changes that Git detects when I open Rider with the original .gitignore: As you can see, that Plugins/Developers/RiderLink/Binaries/ were not being .gitignored by Plugins//Binaries/. Hence my change to make it just Binaries/ Another valid alternative would have been Plugins/**/Binaries/*. If you prefer a more explicit one like that, we can also change it. |
I'd merge it if I had the rights! |
Bump. This change will only cause good. I've closed my dupe #4213 |
Reasons for making this change:
When I installed the Rider plugin for UE5, I noticed that some subfolders with binaries were not being git ignored
Links to documentation supporting these rule changes:
This is the project with which I noticed the issue
https://github.com/Maximetinu/batterycollector-ue5
This is the commit I made to fix it
maximetinu/batterycollector-ue5@71dad49
I've slightly modified the rule for this PR to make it more specific to this case
Steps to reproduce