Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unreal Engine plugin binaries on subfolders #3858

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maximetinu
Copy link

Reasons for making this change:

When I installed the Rider plugin for UE5, I noticed that some subfolders with binaries were not being git ignored

Links to documentation supporting these rule changes:

This is the project with which I noticed the issue

https://github.com/Maximetinu/batterycollector-ue5

This is the commit I made to fix it

maximetinu/batterycollector-ue5@71dad49

I've slightly modified the rule for this PR to make it more specific to this case

Steps to reproduce

  • Pull down that repository prior to the commit I made to fix it
  • Open the project with UE5, enable Rider plugin on the project and open the IDE to see the issue happening

@maximetinu
Copy link
Author

I'm participating in hacktoberfest, so if you can add the hacktoberfest-accepted label to the PR, I'll appreaciate it 😄

@bdougie
Copy link
Contributor

bdougie commented Dec 10, 2021

Unfortunately, we could not make this an Hacktoberfest contribution.

Can you clarify this is an issue happening to other UE5/Rider users?

@maximetinu
Copy link
Author

maximetinu commented Dec 12, 2021

Hi

Yes, other users must also be encountering this.

The original ignore rule is, for example, Plugins//Binaries/. The single * between Plugins and Binaries only contemplates one level of subfolders.

The issue was that the Rider plugin doesn't output its binaries directly to Plugins/Rider/Binaries/, like the original rule assumed. It had the binaries on a deeper subfolder, Plugins/Developer/RiderLink/Binaries/ which was not being git ignored

So I changed the rule to ignore any Intermediate/ and Binaries/ folder, doesn't matter it's depth in the folder hierarchy.

For example, these are the changes that Git detects when I open Rider with the original .gitignore:

image

As you can see, that Plugins/Developers/RiderLink/Binaries/ were not being .gitignored by Plugins//Binaries/. Hence my change to make it just Binaries/

Another valid alternative would have been Plugins/**/Binaries/*. If you prefer a more explicit one like that, we can also change it.

@salmonslay
Copy link

Also having issues with RiderLink and other plugins binary files not being ignored. Is there any reason why it isn't merged yet?

image

@maximetinu
Copy link
Author

I'd merge it if I had the rights!

@jackfranzen
Copy link

Bump. This change will only cause good. I've closed my dupe #4213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants