feat: parse <inertial> elements and joint effort/velocity limits#330
Merged
gkjohnson merged 3 commits intoApr 10, 2026
Merged
Conversation
9d3c29a to
c515bda
Compare
c515bda to
ae7014a
Compare
Owner
|
This is great! Thanks for taking these changes to the finish line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #299 by @dkozma -- this PR is based on their work with review feedback addressed.
Changes
Inertial parsing (
<link>)<inertial>child elements:mass,origin(xyz + rpy), andinertia(ixx, ixy, ixz, iyy, iyz, izz)inertialis always present onURDFLinkwith URDF spec defaults (mass: 0, origin: identity, inertia: zeros), same pattern aslimitonURDFJointnumber[]for origin xyz/rpy (consistent withprocessTuple)copy()toURDFLinkfor the new propertyURDFInertialTypeScript interfaceJoint limits (
<joint>)effortandvelocityfrom<limit>elementsOther
.inertialon URDFLink and.limiton URDFJointmeshPathaddition from Add joint limit and inertial link data #299 (separate concern,LoadingManageris the right approach)Credit
Original work by @dkozma in #299. Review feedback from @gkjohnson addressed in ferrolho@9d3c29a.