feat: govdao v3 better rendering by leohhhn · Pull Request #4164 · gnolang/gno

leohhhn · 2025-04-15T19:30:46Z

Description

Adds better rendering to GovDAO v3. Includes nicer proposal listing, proposal page, and txlinks to vote on proposals.

history repeats.... #3096

Gno2D2 · 2025-04-15T19:31:19Z

🛠 PR Checks Summary

🔴 Must not contain the "don't merge" label

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Must not contain the "don't merge" label
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: leohhhn/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Must not contain the "don't merge" label

If

🟢 Condition met
└── 🟢 A label matches this pattern: don't merge (label: don't merge)

Then

🔴 Requirement not satisfied
└── 🔴 On no pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🟢 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission

codecov · 2025-04-15T20:29:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

leohhhn · 2025-04-15T20:40:14Z

examples/gno.land/r/gov/dao/v3/impl/govdao_test.gno

-	urequire.Equal(t, true, contains(dao.Render(""), "NO PERCENT: 68.42105263157895%"))
-}
-
-func TestProposalPagination(t *testing.T) {


No need to test this, its tested in p/demo/avl/pager already

leohhhn · 2025-04-15T20:42:31Z

examples/gno.land/r/gov/dao/v3/impl/govdao_test.gno

-}
+	println(dao.Render(""))

-func contains(s, substr string) bool {


Also strings.Contains exists

leohhhn · 2025-04-16T10:29:18Z

examples/gno.land/r/gov/dao/v3/impl/render.gno

-	r.HandleFunc("/", func(rw *mux.ResponseWriter, req *mux.Request) {
-		rw.Write(ren.renderActiveProposals(req.RawPath, d))
-	})


this checks for pkgpath:/ so kind of useless as well

thehowl · 2025-04-16T13:59:24Z

examples/gno.land/r/gov/dao/v3/impl/render.gno

+	out += ufmt.Sprintf("[Detailed voting list](%v:%v/votes)", ren.relativeRealmPath, sPid)
+	out += "\n\n---\n\n"
+
+	out += renderActionBar(sPid)


Is this not missing the eligible tiers?

It's given out by out += ps.String()

leohhhn · 2025-04-16T15:15:54Z

Let's wait until we're good with the current impl on the chain and then we can easily upgrade to this.

leohhhn · 2025-05-27T22:26:31Z

Would still love to merge this; I'll try to solve the conflicts

leohhhn · 2025-06-26T12:25:01Z

Updates to the prop reason/name in r/gnoland/users/v1 can be discarded, or taken from this PR: #4415

ie, the "Realm Name Version: Proposal" format is nice.

leohhhn · 2025-07-02T13:36:06Z

Superseded by #4453, thanks @MikaelVallenet. closing.

based on leon PR #4164 what i did its just merge master & fixing tests & introduce crossing --------- Co-authored-by: leohhhn <hudakleon@gmail.com> Co-authored-by: Leon <33522493+leohhhn@users.noreply.github.com>

based on leon PR gnolang#4164 what i did its just merge master & fixing tests & introduce crossing --------- Co-authored-by: leohhhn <hudakleon@gmail.com> Co-authored-by: Leon <33522493+leohhhn@users.noreply.github.com>

better rendering

9d9a5de

github-project-automation bot added this to 🧙‍♂️Gno.land development and 💪 Bounties & Worx Apr 15, 2025

github-project-automation bot moved this to Triage in 🧙‍♂️Gno.land development Apr 15, 2025

leohhhn requested a review from ajnavarro April 15, 2025 19:30

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Apr 15, 2025

github-actions bot assigned leohhhn Apr 15, 2025

Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 15, 2025

chore: fixup

1cacd12

leohhhn commented Apr 15, 2025

View reviewed changes

leohhhn added 3 commits April 15, 2025 22:44

chore: fixup

f2edc21

chore: fixup

4bcc36e

fix tests

f7dd727

Kouteki moved this from Triage to In Review in 🧙‍♂️Gno.land development Apr 16, 2025

leohhhn commented Apr 16, 2025

View reviewed changes

chore: fixup

24a52e7

github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 16, 2025

thehowl reviewed Apr 16, 2025

View reviewed changes

Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 16, 2025

thehowl approved these changes Apr 16, 2025

View reviewed changes

github-project-automation bot moved this to In Progress in 💪 Bounties & Worx Apr 16, 2025

leohhhn added the don't merge Please don't merge this functionality temporarily label Apr 16, 2025

jaekwon force-pushed the master branch from d3e0886 to 705e0df Compare May 3, 2025 20:18

thehowl marked this pull request as draft May 28, 2025 09:07

Kouteki moved this from In Review to Todo in 🧙‍♂️Gno.land development Jun 2, 2025

MikaelVallenet mentioned this pull request Jul 1, 2025

feat(govdao): enhance rendering #4453

Merged

leohhhn closed this Jul 2, 2025

github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Jul 2, 2025

github-project-automation bot moved this from Todo to Done in 🧙‍♂️Gno.land development Jul 2, 2025

Comments

Conversation

leohhhn commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Gno2D2 commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Then

If

Then

If

Can be checked by

Uh oh!

codecov bot commented Apr 15, 2025

Codecov Report

Uh oh!

leohhhn Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

leohhhn Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

leohhhn Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

thehowl Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

leohhhn Apr 16, 2025

Choose a reason for hiding this comment

Uh oh!

leohhhn commented Apr 16, 2025

Uh oh!

leohhhn commented May 27, 2025

Uh oh!

leohhhn commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leohhhn commented Jul 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leohhhn commented Apr 15, 2025 •

edited

Loading

Gno2D2 commented Apr 15, 2025 •

edited

Loading

leohhhn commented Jun 26, 2025 •

edited

Loading