Skip to content

Comments

feat(govdao): enhance rendering#4453

Merged
leohhhn merged 38 commits intognolang:masterfrom
MikaelVallenet:mikael/govdao3-rendering
Jul 9, 2025
Merged

feat(govdao): enhance rendering#4453
leohhhn merged 38 commits intognolang:masterfrom
MikaelVallenet:mikael/govdao3-rendering

Conversation

@MikaelVallenet
Copy link
Member

@MikaelVallenet MikaelVallenet commented Jul 1, 2025

based on leon PR #4164
what i did its just merge master & fixing tests & introduce crossing

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jul 1, 2025
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Jul 1, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jul 1, 2025

🛠 PR Checks Summary

🔴 Must not contain the "don't merge" label

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🔴 Must not contain the "don't merge" label
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: MikaelVallenet/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Must not contain the "don't merge" label

If

🟢 Condition met
└── 🟢 A label matches this pattern: don't merge (label: don't merge)

Then

🔴 Requirement not satisfied
└── 🔴 On no pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@MikaelVallenet MikaelVallenet requested a review from leohhhn July 1, 2025 09:47
@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@MikaelVallenet
Copy link
Member Author

i also added explanation about the fact that username should start with 3 letters instead of characters that is not explicit and add a rule that explain the letters must be lowercase: 9851ccd cc @leohhhn

@MikaelVallenet MikaelVallenet requested a review from leohhhn July 2, 2025 18:21
@leohhhn leohhhn requested a review from ajnavarro July 3, 2025 09:49
@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️Gno.land development Jul 3, 2025
@leohhhn
Copy link
Contributor

leohhhn commented Jul 7, 2025

I think gno lint is timing out and being red because it's become super slow for some reason. The origin of the problem might be the latest mempackage PR?

@Kouteki Kouteki added this to the ⏭️Next after mainnet beta milestone Jul 7, 2025
@leohhhn leohhhn merged commit 9ca7771 into gnolang:master Jul 9, 2025
65 of 68 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in 💪 Bounties & Worx Jul 9, 2025
stefann-01 pushed a commit to stefann-01/gno that referenced this pull request Jul 14, 2025
based on leon PR gnolang#4164
what i did its just merge master & fixing tests & introduce crossing

---------

Co-authored-by: leohhhn <hudakleon@gmail.com>
Co-authored-by: Leon <33522493+leohhhn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤝 contribs don't merge Please don't merge this functionality temporarily 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants