Skip to content

Conversation

@moul
Copy link
Member

@moul moul commented Nov 28, 2025

Alternative for #4905

Kept:

  • Removed GetRaw/SetRaw since GetBytes/SetBytes can be used as a replacement.
  • SetBytes to use directly the store, preventing the value to be aminoJSON encoded.

Updated:

  • Preserve API consistency.

SetBytes is used by the IBC contract to store the commitment bytes. Then
the relayer submit the proof of existence of those bytes to the counter
party chain, but if the value bytes are different, the proof cannot be
verified.

This PR updates SetBytes to use directly the store instead of passing by
the common `set` method, preventing the value to be aminoJSON encoded.

Removed GetRaw/SetRaw since GetBytes/SetBytes can be used as a
replacement.
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Nov 28, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@moul moul changed the title 4905 alt1 fix(params): SetBytes should not alter the value bytes (alternative) Nov 28, 2025
@moul moul changed the title fix(params): SetBytes should not alter the value bytes (alternative) WIP fix(params): SetBytes should not alter the value bytes (alternative) Nov 28, 2025
@moul moul changed the title WIP fix(params): SetBytes should not alter the value bytes (alternative) fix(params): SetBytes should not alter the value bytes (alternative) Nov 28, 2025
@moul moul marked this pull request as ready for review November 28, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related

Projects

Status: No status
Status: 📥 Inbox
Status: Triage

Development

Successfully merging this pull request may close these issues.

3 participants