actions: overlay: Check source exists in recipedir early #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
bors try |
sjoerdsimons
requested changes
Apr 28, 2022
Contributor
tryBuild failed: |
obbardc
changed the title
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
12bd81a to
9a89ebe
Compare
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
9a89ebe to
add9a02
Compare
sjoerdsimons
requested changes
Jan 13, 2024
tests/overlay-non-existent-destination/overlay-non-existent-destination.yaml
Outdated
Show resolved
Hide resolved
tests/overlay-non-existent-destination/overlay-non-existent-destination.yaml
Outdated
Show resolved
Hide resolved
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
add9a02 to
6a99870
Compare
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
6a99870 to
acf2bfc
Compare
obbardc
changed the title
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
acf2bfc to
7f31bf0
Compare
Member
Author
|
@sjoerdsimons I've rebased this PR on main, fixed the merge issues & updated the commit messages to be a bit more sane. |
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
7f31bf0 to
2e9a9c1
Compare
If an overlay (with a source from the recipe directory which is unlikely to change during execution) doesn't exist, the recipe errors out during execution. Change the logic to check early (in the verification stage) if the overlay exists on the host filesystem inside the recipe directory, if the overlay source is from the recipedir. Signed-off-by: Christopher Obbard <[email protected]>
We now error out early if trying to overlay files which don't exist in recipedir. Add a test for it. Signed-off-by: Christopher Obbard <[email protected]>
obbardc
force-pushed
the
wip/obbardc/overlay-check-source-exists
branch
from
2e9a9c1 to
1e40464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an overlay coming from the recipe directory doesn't
exist, the recipe exits during execution. Let's check
early if the overlay exists on the host filesystem.