actions: overlay: Check source exists in recipedir early

actions/overlay_action.go

@@ -27,6 +27,7 @@ package actions
 import (
 	"fmt"
 	"log"
+	"os"
 	"path"
 
 	"github.com/go-debos/debos"
@@ -43,6 +44,15 @@ func (overlay *OverlayAction) Verify(context *debos.Context) error {
 	if _, err := debos.RestrictedPath(context.Rootdir, overlay.Destination); err != nil {
 		return err
 	}
+
+	/* if origin is the recipe, check the path exists on disk */
+	if len(overlay.Origin) == 0 || overlay.Origin == "recipe" {
+		sourceDir := path.Join(context.RecipeDir, overlay.Source)
+		if _, err := os.Stat(sourceDir); err != nil {
+			return err
+		}
+	}
+
 	return nil
 }
 

tests/exit_test/exit_test.sh

@@ -68,6 +68,7 @@ expect_failure debos bad.yaml
 expect_failure debos pre-machine-failure.yaml
 expect_failure debos post-machine-failure.yaml
 expect_failure debos overlay-non-existent-destination.yaml
+expect_failure debos overlay-non-existent-source.yaml
 expect_failure rename_command NOT_DEBOS debos good.yaml
 
 expect_failure $SUDO debos non-existent-file.yaml --disable-fakemachine
@@ -79,6 +80,7 @@ expect_failure $SUDO debos bad.yaml --disable-fakemachine
 expect_failure $SUDO debos pre-machine-failure.yaml --disable-fakemachine
 expect_failure $SUDO debos post-machine-failure.yaml --disable-fakemachine
 expect_failure $SUDO debos overlay-non-existent-destination.yaml --disable-fakemachine
+expect_failure $SUDO debos overlay-non-existent-source.yaml --disable-fakemachine
 
 echo
 if [[ $FAILURES -ne 0 ]]; then

tests/exit_test/overlay-non-existent-source.yaml

@@ -0,0 +1,8 @@
+architecture: amd64
+
+actions:
+  # This overlay action is expected to error out here because the source
+  # doesn't exist in the recipe directory.
+  - action: overlay
+    description: Overlay missing file
+    source: missing-file