Rework Create release functions by lunny · Pull Request #36621 · go-gitea/gitea

lunny · 2026-02-14T06:24:24Z

Add a tag name invalidate name error check when creating tag from the UI
Rework CreateRelease, CreateNewTag and UpdateRelease
Fix the bug it will never work when creating a release from a UI-created-tag.

wxiaoguang · 2026-02-14T06:28:00Z

"// Trim '--' prefix to prevent command line argument vulnerability."

How it can be right? Where is the vulnerability? If you think there is a vulnerability, why don't you fix the branch names?

lunny · 2026-02-14T06:53:07Z

"// Trim '--' prefix to prevent command line argument vulnerability."

How it can be right? Where is the vulnerability? If you think there is a vulnerability, why don't you fix the branch names?

Removed at 9e37d1b which introduced at 0a78d99#diff-ff6356f0c6f4aae97d82e1c488527eb91065a8a7e474add4e74cdc5bd167f7caR70-R71

lunny · 2026-02-17T19:48:58Z

This is ready to review now.

Copilot

Pull request overview

Reworks release/tag creation flows to support UI-created tags, adds invalid tag name checks, and threads request context through release service calls.

Changes:

Introduced createGitTag and refactored CreateRelease, CreateNewTag, and UpdateRelease to use context.Context and handle existing tags.
Updated web/API/test call sites to pass context into CreateRelease.
Improved branch creation error handling by adding invalid tag name feedback.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/integration/mirror_pull_test.go	Updates integration test to pass context into `CreateRelease`.
services/release/release_test.go	Updates tests for new `CreateRelease` signature and adds basic `createGitTag` coverage.
services/release/release.go	Major refactor: new `createGitTag`, context-aware `CreateRelease`, updated `CreateNewTag` + `UpdateRelease` logic.
routers/web/repo/release.go	Updates UI release creation to call new `CreateRelease(ctx, ...)` and removes pre-check for target branch existence.
routers/web/repo/branch.go	Refactors error handling and adds handling for invalid tag names.
routers/api/v1/repo/release.go	Updates API endpoint to call new `CreateRelease(ctx, ...)`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

services/release/release.go

routers/web/repo/release.go

services/release/release_test.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

options/locale/locale_en-US.json

wxiaoguang · 2026-02-22T15:48:37Z

services/release/release.go

+	if rel.Repo == nil || rel.Publisher == nil {
+		return errors.New("repo or publisher is not loaded")
+	}


It is definitely a programming error, why you tolerate it to happen?

wxiaoguang · 2026-02-22T15:49:28Z

services/release/release.go

+	switch {
+	case err == nil:
+		return nil
+	case strings.Contains(err.Error(), "is not a valid tag name"):


wxiaoguang · 2026-02-22T15:50:36Z

routers/web/repo/release.go

 		case release_service.IsErrProtectedTagName(err):
 			ctx.RenderWithErr(ctx.Tr("repo.release.tag_name_protected"), tplReleaseNew, &form)
+		case git.IsErrNotExist(err):
+			ctx.RenderWithErr(ctx.Tr("repo.release.tag_target_not_exist", form.Target), tplReleaseNew, &form)


You should use new JSON-based "form-fetch-action", instead of the fragile RenderWithErr. In most cases, RenderWithErr is wrong and the template is not able to recover to the correct state.

wxiaoguang · 2026-02-22T15:53:26Z

services/release/release.go

-				return false, ErrProtectedTagName{
-					TagName: rel.TagName,
+			if rel.PublisherID <= 0 {
+				u, err := user_model.GetUserByEmail(ctx, commit.Author.Email)


Why you trust the commit's email and use it for Gitea's user?

Does it mean that I can use your email to create a commit then create a release, and then the publisher is recognized as you?

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>

lunny added 2 commits February 13, 2026 21:52

Rework Create release functions

089ea79

Fix bug

b56a820

lunny added type/bug type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Feb 14, 2026

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 14, 2026

github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Feb 14, 2026

lunny added 2 commits February 13, 2026 22:34

Fix bug

ce2c6a6

Remove unnecessary check and add name error check when creating tag

9e37d1b

lunny added 7 commits February 13, 2026 23:04

Fix bug

36ee22d

Merge branch 'main' into lunny/rework_create_release

aa11611

Fix test

10bbf6e

Merge branch 'main' into lunny/rework_create_release

f55af0e

Fix lint

a9336c7

Fix bug

7501af4

Merge branch 'main' into lunny/rework_create_release

7601a1d

lunny marked this pull request as ready for review February 17, 2026 19:47

silverwind requested a review from Copilot February 18, 2026 03:23

Copilot started reviewing on behalf of silverwind February 18, 2026 03:28 View session

Copilot AI reviewed Feb 18, 2026

View reviewed changes

lunny and others added 7 commits February 17, 2026 19:35

Update services/release/release.go

5708f62

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>

Update services/release/release.go

47fb9ee

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>

improvement

695cb22

Update services/release/release_test.go

296ca77

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>

Fix test

e15490a

Fix bug

5e28858

Merge branch 'main' into lunny/rework_create_release

f3102d4

Merge branch 'main' into lunny/rework_create_release

5467918

silverwind requested a review from Copilot February 22, 2026 14:25

Copilot started reviewing on behalf of silverwind February 22, 2026 14:26 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

options/locale/locale_en-US.json Outdated Show resolved Hide resolved

wxiaoguang reviewed Feb 22, 2026

View reviewed changes

wxiaoguang marked this pull request as draft February 22, 2026 15:53

Update options/locale/locale_en-US.json

ff4785f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Lunny Xiao <xiaolunwen@gmail.com>

Uh oh!

Comments

Conversation

lunny commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wxiaoguang commented Feb 14, 2026

Uh oh!

lunny commented Feb 14, 2026

Uh oh!

lunny commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

wxiaoguang Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

wxiaoguang Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lunny commented Feb 14, 2026 •

edited

Loading

wxiaoguang Feb 22, 2026 •

edited

Loading