Rework Create release functions

options/locale/locale_en-US.json

@@ -2629,6 +2629,7 @@
   "repo.release.tag_name_invalid": "The tag name is not valid.",
   "repo.release.tag_name_protected": "The tag name is protected.",
   "repo.release.tag_already_exist": "This tag name already exists.",
+  "repo.release.tag_target_not_exist": "The tag target does not exist.",
   "repo.release.downloads": "Downloads",
   "repo.release.download_count": "Downloads: %s",
   "repo.release.add_tag_msg": "Use the title and content of release as tag message.",

routers/api/v1/repo/release.go

@@ -249,7 +249,7 @@ func CreateRelease(ctx *context.APIContext) {
 		}
 		// GitHub doesn't have "tag_message", GitLab has: https://docs.gitlab.com/api/releases/#create-a-release
 		// It doesn't need to be the same as the "release note"
-		if err := release_service.CreateRelease(ctx.Repo.GitRepo, rel, nil, form.TagMessage); err != nil {
+		if err := release_service.CreateRelease(ctx, ctx.Repo.GitRepo, rel, nil, form.TagMessage); err != nil {
 			if repo_model.IsErrReleaseAlreadyExist(err) {
 				ctx.APIError(http.StatusConflict, err)
 			} else if release_service.IsErrProtectedTagName(err) {

routers/web/repo/branch.go

@@ -200,30 +200,22 @@ func CreateBranch(ctx *context.Context) {
 		err = repo_service.CreateNewBranchFromCommit(ctx, ctx.Doer, ctx.Repo.Repository, ctx.Repo.CommitID, form.NewBranchName)
 	}
 	if err != nil {
-		if release_service.IsErrProtectedTagName(err) {
+		switch {
+		case release_service.IsErrProtectedTagName(err):
 			ctx.Flash.Error(ctx.Tr("repo.release.tag_name_protected"))
 			ctx.Redirect(ctx.Repo.RepoLink + "/src/" + ctx.Repo.RefTypeNameSubURL())
-			return
-		}
-
-		if release_service.IsErrTagAlreadyExists(err) {
+		case release_service.IsErrTagAlreadyExists(err):
 			e := err.(release_service.ErrTagAlreadyExists)
 			ctx.Flash.Error(ctx.Tr("repo.branch.tag_collision", e.TagName))
 			ctx.Redirect(ctx.Repo.RepoLink + "/src/" + ctx.Repo.RefTypeNameSubURL())
-			return
-		}
-		if git_model.IsErrBranchAlreadyExists(err) || git.IsErrPushOutOfDate(err) {
+		case git_model.IsErrBranchAlreadyExists(err) || git.IsErrPushOutOfDate(err):
 			ctx.Flash.Error(ctx.Tr("repo.branch.branch_already_exists", form.NewBranchName))
 			ctx.Redirect(ctx.Repo.RepoLink + "/src/" + ctx.Repo.RefTypeNameSubURL())
-			return
-		}
-		if git_model.IsErrBranchNameConflict(err) {
+		case git_model.IsErrBranchNameConflict(err):
 			e := err.(git_model.ErrBranchNameConflict)
 			ctx.Flash.Error(ctx.Tr("repo.branch.branch_name_conflict", form.NewBranchName, e.BranchName))
 			ctx.Redirect(ctx.Repo.RepoLink + "/src/" + ctx.Repo.RefTypeNameSubURL())
-			return
-		}
-		if git.IsErrPushRejected(err) {
+		case git.IsErrPushRejected(err):
 			e := err.(*git.ErrPushRejected)
 			if len(e.Message) == 0 {
 				ctx.Flash.Error(ctx.Tr("repo.editor.push_rejected_no_message"))
@@ -240,10 +232,12 @@ func CreateBranch(ctx *context.Context) {
 				ctx.Flash.Error(flashError)
 			}
 			ctx.Redirect(ctx.Repo.RepoLink + "/src/" + ctx.Repo.RefTypeNameSubURL())
-			return
+		case release_service.IsErrInvalidTagName(err):
+			ctx.Flash.Error(ctx.Tr("repo.release.tag_name_invalid"))
+			ctx.Redirect(ctx.Repo.RepoLink + "/src/" + ctx.Repo.RefTypeNameSubURL())
+		default:
+			ctx.ServerError("CreateNewBranch", err)
 		}
-
-		ctx.ServerError("CreateNewBranch", err)
 		return
 	}
 

routers/web/repo/release.go

@@ -451,11 +451,6 @@ func NewReleasePost(ctx *context.Context) {
 		return
 	}
 
-	if exist, _ := git_model.IsBranchExist(ctx, ctx.Repo.Repository.ID, form.Target); !exist {
-		ctx.RenderWithErr(ctx.Tr("form.target_branch_not_exist"), tplReleaseNew, &form)
-		return
-	}
-
 	if !form.TagOnly && form.Title == "" {
 		// if not "tag only", then the title of the release cannot be empty
 		ctx.RenderWithErr(ctx.Tr("repo.release.title_empty"), tplReleaseNew, &form)
@@ -473,6 +468,8 @@ func NewReleasePost(ctx *context.Context) {
 			ctx.RenderWithErr(ctx.Tr("repo.release.tag_name_invalid"), tplReleaseNew, &form)
 		case release_service.IsErrProtectedTagName(err):
 			ctx.RenderWithErr(ctx.Tr("repo.release.tag_name_protected"), tplReleaseNew, &form)
+		case git.IsErrNotExist(err):
+			ctx.RenderWithErr(ctx.Tr("repo.release.tag_target_not_exist", form.Target), tplReleaseNew, &form)
 		default:
 			ctx.ServerError("handleTagReleaseError", err)
 		}
@@ -512,7 +509,7 @@ func NewReleasePost(ctx *context.Context) {
 			IsPrerelease: form.Prerelease,
 			IsTag:        false,
 		}
-		if err = release_service.CreateRelease(ctx.Repo.GitRepo, rel, attachmentUUIDs, newTagMsg); err != nil {
+		if err = release_service.CreateRelease(ctx, ctx.Repo.GitRepo, rel, attachmentUUIDs, newTagMsg); err != nil {
 			handleTagReleaseError(err)
 			return
 		}