Iter optimization clean up #974
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
added
student-job
performance
Member
Closed
Contributor
Author
|
Yes, there should be a similar rebase of #965 within the next days. |
Contributor
Member
michael-schwarz
left a comment
michael-schwarz
left a comment
There was a problem hiding this comment.
Thanks for the PR! As discussed on the other PR, we will likely merge the alternative #975 though :)
| module WeakUpdates = BaseDomain.WeakUpdates | ||
| module BaseComponents = BaseDomain.BaseComponents | ||
|
|
||
| open Iter |
Member
There was a problem hiding this comment.
As far as I can see, this open is unused?
Contributor
Author
There was a problem hiding this comment.
Yes, that is correct, this open isn't needed.
| in | ||
| let alen = List.filter_map (fun v -> lenOf v.vtype) (AD.to_var_may a) in | ||
| let d = List.fold_left ID.join (ID.bot_of (Cilfacade.ptrdiff_ikind ())) (List.map (ID.of_int (Cilfacade.ptrdiff_ikind ()) %BI.of_int) (slen @ alen)) in | ||
| let d = Iter.((Iter.map String.length (Iter.of_list @@ AD.to_string a)) <+> (Iter.filter_map (fun v -> lenOf v.vtype) (Iter.of_list @@ AD.to_var_may a)) (*<- equal to slen @ alen *) |
Member
There was a problem hiding this comment.
If you already have Iter.(...) outside, you do not need it inside again.
Contributor
Author
There was a problem hiding this comment.
Right, that somehow slipped my mind. Should I push a fix for that even though the code deadline has passed?
Member
|
As we will not move ahead with Iter, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cleaned up version of PR #964
As discussed, I created a new PR containing only the relevant Iter related changes. This PR is now based on the merged
flambdaPR #928.In particular, it is based on the commit https://github.com/goblint/analyzer/commit/ab2141a00b577cb20d354878a315a2e27e5074c6
.
All relevant information can be found in the comments of #964.