Seq-optimization clean version #975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
Compared to #974, it has this change which isn't present here: https://github.com/goblint/analyzer/pull/974/files#diff-969b2ca0b7175f19daa5deae1308a02718e8cd1927a4d8e160541a35e57c31dbL1376-R1380. Is there a reason for that? |
michael-schwarz
approved these changes
Feb 3, 2023
jerhard
approved these changes
Feb 3, 2023
sim642
approved these changes
Feb 3, 2023
Member
sim642
left a comment
sim642
left a comment
There was a problem hiding this comment.
The changes themselves are fine, I was just wondering about my previous point: #975 (comment).
Member
|
We discussed this with our students offline yesterday, one of places you mentioned above actually only does a fold, so there's no point. For the one using sort we didn't think it makes much sense as the introduction won't save anything there, as the entire list needs to be considered to sort it anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a clean up version of #965 and contains only the Seq changes.