Skip to content

UX Improvements to shareable certificates #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ideadude merged 13 commits into from
Jun 26, 2024
Merged

UX Improvements to shareable certificates #1387

Changes from 6 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
105d8b6
change save to download and display cert permalink for #1379
imknight Oct 16, 2020
08afa89
remove unwantedy style and clean up
imknight Oct 16, 2020
de0b1c1
fixed style
imknight Oct 16, 2020
7e93fb0
convert from span into input
imknight Oct 19, 2020
9a6532a
UX improvement to url field
imknight Oct 21, 2020
eb08c3c
change it into inline js function
imknight Oct 23, 2020
7ed4035
Update templates/content-certificate.php
brianhogg May 29, 2024
f68075b
Merge branch 'trunk' into bug-fix-1379
brianhogg Jun 3, 2024
21ef79d
Re-adding changes in new location.
brianhogg Jun 3, 2024
0ceed28
Adding changelog.
brianhogg Jun 3, 2024
2641a09
Adding escaping. Switching to copy to clipboard button.
brianhogg Jun 4, 2024
a62ee62
Merge branch 'dev' into bug-fix-1379
brianhogg Jun 4, 2024
daa5227
Merge branch 'dev' into bug-fix-1379
ideadude Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion templates/content-certificate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

<form action="" method="POST">
<button class="llms-button-secondary" type="submit" name="llms_generate_cert">
<?php echo _e( 'Save', 'lifterlms' ); ?>
<?php echo _e( 'Download', 'lifterlms' ); ?>
<i class="fa fa-cloud-download" aria-hidden="true"></i>
</button>
<?php if ( get_post_type( $cert->get( 'id' ) ) === $cert->get( 'db_post_type' ) ) : ?>
Expand All @@ -54,6 +54,10 @@
</button>
<?php endif; ?>

<?php if ( $is_sharing_enabled ) : ?>
<input readonly="readonly" id="llms_sharing_permalink" onClick="this.select();" value="<?php echo esc_url( get_permalink( get_the_ID() ) ); ?>">
<?php endif; ?>

<input type="hidden" name="certificate_id" value="<?php echo get_the_ID(); ?>">
<?php wp_nonce_field( 'llms-cert-actions', '_llms_cert_actions_nonce' ); ?>
</form>
Expand Down