GD-1031: Test session should be properly stopped when using the Stop button or shortcuts #1052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSchulze
changed the title
MikeSchulze
force-pushed
the
GD-1031
branch
3 times, most recently
from
fcd3d75 to
3179378
Compare
…or shortcuts # Why When pressing the "Stop" button or using keyboard shortcuts to abort a test session, the test runner is forcibly killed rather than gracefully shut down, resulting in resource leaks and improper cleanup of test hooks. - Using “EditorInterface.stop_playing_scene()” abruptly terminates the external Godot process, so we don't have a controlled shutdown. # What - We do not end the current scene with “EditorInterface.stop_playing_scene()”, but instead use a ‘gdunit_test_session_terminate’ signal to send an “RPCClientDisconnect” command to the client so that the test run is terminated properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When pressing the "Stop" button or using keyboard shortcuts to abort a test session, the test runner is forcibly killed rather than gracefully shut down, resulting in resource leaks and improper cleanup of test hooks.
What