GD-1055: Revisit the simulate_key_.. API and make the modifier arguments deprecated
#1056
+343
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
…ests # Why After reviewing the test coverage of “simulate key” once again, I decide to revise it to improve it. # What Revision of simulation tests for keys with modifiers and correction of incorrect assumptions for creating key events. Adding more specific use cases - pressing SHIFT+A - pressing A+SHIFT - releasing SHIFT+A - pressed SHIFT+A - pressing A and use modifier SHIFT - releasing A and use modifier SHIFT - pressed A and use modifier SHIFT Evaluate the builded events by using SPY to verify the input events is build like using the `addons\gdUnit4\test\core\InputEventTestScene.tscn` - Fixes wrong setting key input event modifieres
This was referenced Jan 6, 2026
MikeSchulze
changed the title
simulate_key_.. API and make the modifier arguments deprecated
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
After reviewing the test coverage of “simulate key” once again, I decide to revise it to improve it.
What
Revision of simulation tests for keys with modifiers and correction of incorrect assumptions for creating key events. Adding more specific use cases
Evaluate the built events by using an SPY to verify the input events are built like the Godot engine by using the
addons\gdUnit4\test\core\InputEventTestScene.tscnsimulate_key_pressed,simulate_key_press,simulate_key_releaseas deprecated