Fixing GD Paint Issues in 4.0-dev #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
reviewed
May 7, 2022
Member
aaronfranke
left a comment
aaronfranke
left a comment
There was a problem hiding this comment.
Thanks for these fixes! It works well on my system. But the panel's background color seems a bit bright.
Contributor
Author
You're welcome. I'm glad that I found out what was causing that strange saving bug. |
aaronfranke
approved these changes
May 7, 2022
aaronfranke
requested changes
May 7, 2022
2d/gd_paint/tools_panel.gd
Outdated
| func background_color_changed(color): | ||
| # Change the background color to whatever colorthe background color picker is. | ||
| get_parent().get_node(^"DrawingAreaBG").modulate = color | ||
| get_parent().find_child(^"DrawingAreaBG").modulate = color |
Member
There was a problem hiding this comment.
Why was this changed? This should still be get_node.
Contributor
Author
There was a problem hiding this comment.
Aah that got changed because I was testing with viewport containers instead. It was during the testing of SubViewports that I discovered the solution. Will change it right now!
aaronfranke
approved these changes
May 8, 2022
The clipping happened because the panel was see-through. The saving is also fixed by changing some of the project settings. Update 2d/gd_paint/paint_root.tscn Co-authored-by: Aaron Franke <[email protected]> changeback to get_node
aaronfranke
approved these changes
May 8, 2022
Member
|
Thanks for all of your work! |
Contributor
Author
I'm happy that I can help. ^^/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clipping happened because the panel was see-through.
The saving is also fixed by changing some of the project settings.
To fix the issues from #734