Skip to content

Add documentation for themed icons (monochrome) #10034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2024
Merged

Add documentation for themed icons (monochrome) #10034

merged 1 commit into from
Oct 7, 2024

Conversation

syntaxerror247
Copy link
Member

This PR add documentation for themed icons i.e. implemented in godotengine/godot#97517

AThousandShips
AThousandShips reviewed Oct 2, 2024
View reviewed changes
@AThousandShips AThousandShips added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:export platform:android labels Oct 2, 2024
@AThousandShips AThousandShips requested a review from a team October 2, 2024 15:53
@AThousandShips AThousandShips added this to the 4.4 milestone Oct 2, 2024
@syntaxerror247 syntaxerror247 marked this pull request as draft October 2, 2024 16:28
@syntaxerror247 syntaxerror247 marked this pull request as ready for review October 2, 2024 19:42
mhilbrunner
mhilbrunner approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing, and also for taking care of also adding documentation for your work :)

@skyace65
Copy link
Contributor

skyace65 commented Oct 6, 2024

Just let me know before merging, so I can rebase this again.

Why do you need to rebase this again?

@syntaxerror247
Copy link
Member Author

I have deleted that comment, I just realised that was dumb.

@skyace65 skyace65 merged commit 7cd9621 into godotengine:master Oct 7, 2024
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Oct 7, 2024

Thanks!

@syntaxerror247 syntaxerror247 deleted the docs-for-themed-icons branch October 8, 2024 01:16
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@skyace65 skyace65 skyace65 approved these changes

@radiantgurl radiantgurl radiantgurl approved these changes

@AThousandShips AThousandShips Awaiting requested review from AThousandShips

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation platform:android topic:export
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@syntaxerror247 @skyace65 @mhilbrunner @radiantgurl @AThousandShips