Update WebSocket documentation for Godot 4 #7645
Open
+104
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
the
area:manual
|
You need a newline at the end of the file, see the checks for details |
|
Please squash your commits into one, see here |
TranquilMarmot
force-pushed
the
websockets-4
branch
from
24281bf to
fa8cd06
Compare
Co-authored-by: A Thousand Ships <[email protected]>
TranquilMarmot
force-pushed
the
websockets-4
branch
from
2815c79 to
7395d94
Compare
|
@AThousandShips thanks for the style fixes! I merged them and squashed the commits. |
Techyguy1234
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebSocketClientandWebSocketServerwere removed from Godot 4.For the minimal client, I basically copied what was in the docstring for
WebSocketPeer.I changed the client example to point to
postman-echo.comsince I couldn't figure out how to set the protocol (lws-mirror-protocolin the old example) withWebSocketPeer. If anybody knows how to set that, we can change it back- although I prefer the example without the protocol since that was confusing to me when I first read through it.I'm also not certain that the server example here is correct.
Do you really have to keep track of peer IDs manually? I didn't see a way to get a list of connected peers on the
WebSocketServerDoes the
peerneed to be polled as well as the server? I could never trigger it getting a packet from a peer, but maybe I was testing it incorrectly.