Skip to content

Improve Project Manager UI navigation #101129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rindbee
Copy link
Contributor

@Rindbee Rindbee commented Jan 4, 2025

Provides a focus stylebox for navigable controls.

The focused project is automatically selected. This resolves the conflict in the handling of Key::UP/Key::DOWN in ProjectManager::shortcut_input() and Viewport::_gui_input_event().

Before:

001.mp4

After:

002.mp4

There may be frame drops in the recorded video.

@Rindbee Rindbee force-pushed the improve-project-manager-ui-navigation branch from 6f0b533 to 131140c Compare January 4, 2025 15:33
@syntaxerror247 syntaxerror247 requested review from a team and removed request for a team January 4, 2025 15:41
@syntaxerror247 syntaxerror247 added this to the 4.x milestone Jan 4, 2025
@Rindbee Rindbee force-pushed the improve-project-manager-ui-navigation branch 2 times, most recently from 87fe8fb to 4024258 Compare January 5, 2025 00:34
@Rindbee Rindbee force-pushed the improve-project-manager-ui-navigation branch 3 times, most recently from b95548d to 9743dd5 Compare January 19, 2025 01:06
@Rindbee Rindbee force-pushed the improve-project-manager-ui-navigation branch from 9743dd5 to 5b1690e Compare January 19, 2025 23:30
@Rindbee Rindbee force-pushed the improve-project-manager-ui-navigation branch from 5b1690e to f32a7e6 Compare January 20, 2025 00:01
@KoBeWi KoBeWi modified the milestones: 4.x, 4.5 Jan 20, 2025
Provides a focus stylebox for navigable controls.

The focused project is automatically selected. This resolves the conflict in
the handling of `Key::UP`/`Key::DOWN` in `ProjectManager::shortcut_input()`
and `Viewport::_gui_input_event()`.
@Rindbee Rindbee force-pushed the improve-project-manager-ui-navigation branch from f32a7e6 to 6f7411a Compare January 20, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants