Improve Project Manager UI navigation #101129
Open
+61
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
from
6f0b533 to
131140c
Compare
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
2 times, most recently
from
87fe8fb to
4024258
Compare
KoBeWi
reviewed
Jan 18, 2025
KoBeWi
reviewed
Jan 18, 2025
KoBeWi
reviewed
Jan 18, 2025
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
3 times, most recently
from
b95548d to
9743dd5
Compare
KoBeWi
reviewed
Jan 19, 2025
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
from
9743dd5 to
5b1690e
Compare
KoBeWi
reviewed
Jan 19, 2025
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
from
5b1690e to
f32a7e6
Compare
KoBeWi
approved these changes
Jan 20, 2025
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
from
f32a7e6 to
6f7411a
Compare
|
Apologies for the delay, this went under the radar until now. I'm sorting through older approved PRs as we reach feature freeze... so this might be postponed again to 4.6. This time I'm putting it in the merge queue so it's not forgotten. This will need a rebase. |
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
from
6f7411a to
4eecf30
Compare
|
Added some shortcuts because the favorite and explore buttons are a bit small. In particular, when switching favorites (clicking the favorite button with the mouse or pressing the |
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
from
4eecf30 to
2c722f2
Compare
Provide a focus stylebox for navigable controls. Add shortcuts for explore (`E`) and favorite (`F`). In particular, when switching favorites (clicking the favorite button with the mouse or pressing the `F` key), pressing `ALT` will follow the item.
Rindbee
force-pushed
the
improve-project-manager-ui-navigation
branch
from
2c722f2 to
f65f3f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a focus stylebox for navigable controls.
The focused project is automatically selected. This resolves the conflict in the handling ofKey::UP/Key::DOWNinProjectManager::shortcut_input()andViewport::_gui_input_event().Edit:
The above issue has been fixed by 302fa83 (#76829)
master (09ed9d4) :
000.mp4
this pr:
001.mp4