Fix node cache errors on nested MultiplayerSpawners #101416
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes spawned_nodes to an RBSet, which preserves insertion order after entries are removed. This prevents simplify path commands from being sent to clients out of order, so that the commands for parents are recieved before the commands for children. This may not be the right fix (data structure, or design).
|
I have tested it and the fix works very well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #91342 by changing the replication node tracking logic to use RBSet, which preserves iteration order after entries are removed.
This prevents simplify path commands from being sent to clients out of order, so that the commands for parents are received before the commands for children.
This may not be the right fix but it does fix the MRP in issue #91342 and my own personal project where I have three layers of nested spawners which were reproducing the same issue.
Looking for feedback or hoping this inspires a proper fix :)