Clarify XRController3D get_input name corresponds to actions in the action set

[lodetrick]

Clarify that the parameter name for the methods get_input, get_float, get_vector2, and is_button_pressed corresponds to the internal name of an action in the current action map. Current docs call it the name of an input.

[dsnopek]

Thanks!

However, this is only true for OpenXR. With WebXR or any other interface from GDExtension, there is no action map. So, if we add something like this, it should specifically mention OpenXR

[lodetrick]

For the other interfaces, is there any standard wording for what name the input is? The current documentation feels a bit vague and unclear, especially for OpenXR (which appears to be the most supported XR framework currently).

[dsnopek]

For the other interfaces, is there any standard wording for what name the input is?

The names are defined by the XRInterface, and that's all we can really say in general.

We could maybe write something like "The name of the input is defined by the [XRInterface]. In the case of OpenXR, these are the names of actions for the current action set."

We could conceivably also link to some docs on the names of the WebXR inputs, but I don't think we have any yet. :-)

[lodetrick]

I wonder if the clarification could be made in the class description, and each method just says to refer to that, rather than having the same description four times. The class description already mentions that inputs are named, so it could just expand upon that. Is there a convention for that sort of thing or should the docs avoid that kind of indirection?

[dsnopek]

Sure, we could add it to the class description - it does match the existing note about "a configurable action map"

[dsnopek]

Thanks! Looks good to me :-)

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉