Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported platforms note for "use system accent color" option #104128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Joseph-DiGiovanni
Copy link
Contributor

Thanks to #104106 I believe all platforms that have accent colors now have the feature implemented, making this note unnecessary.

This PR is for the tool-tip of the theme option in the editor, not the display server documentation.

@Joseph-DiGiovanni Joseph-DiGiovanni requested a review from a team as a code owner March 14, 2025 16:22
@Mickeon
Copy link
Contributor

Mickeon commented Mar 14, 2025

I think the only thing that could be removed here should be "only" in the note, because we tend to use "only" only when a single platform supports the subject in question.

@AThousandShips
Copy link
Member

"Only implemented" is used for multiple cases 6 times, 8 times for a single OS, so there's no such strong tendency

For "only supported" it's 7 for multiple, and 3 for single cases

There's other combinations I didn't look at, but there's no issue with "only" here IMO

@Joseph-DiGiovanni Joseph-DiGiovanni force-pushed the remove-system-accent-color-note branch from 45603fe to a145eef Compare March 14, 2025 18:31
@Joseph-DiGiovanni
Copy link
Contributor Author

I'm personally in favor of removing "only" when the list has grown as long as it has. We may be better off waiting for godotengine/godot-proposals#11993, as it should bring web theme detection to parity with other platforms that the editor currently supports. Then, I believe this note can be safely removed.

@Joseph-DiGiovanni Joseph-DiGiovanni force-pushed the remove-system-accent-color-note branch from a145eef to 64bc1f2 Compare March 14, 2025 18:36
@AThousandShips AThousandShips changed the title Remove supported platforms note from "use system accent color" option Update supported platforms note for "use system accent color" option Mar 14, 2025
@Calinou
Copy link
Member

Calinou commented Mar 15, 2025

In the long term, we'll probably want to add a platforms="windows,linux" attribute to documentable items in the class reference, similar to what #63079 does for notes and warnings (although that one is more free-form). This way, we can standardize these notes and reduce the amount of work needed for translators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants