-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color space blend and alpha notes to Color documentation #104410
base: master
Are you sure you want to change the base?
Conversation
I have a question: doesn't the sRGB encoding ignore the alpha channel by nature? I don't heard of the difference of alpha between sRGB space and linear space and non-linear alpha encoding.
Vulkan VK_FORMAT_R8G8B8A8_SRGB doesn't use non-linear alpha, too. I doubt if non-linear alpha has any use cases. |
You are correct and this PR aims to explicitly state exactly what you described in your comment for those who are unaware of this. |
Since there is no other case about the alpha channel, why is it necessary to explicitly state it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alpha channel often does not exist in the concept of a [color] space (at least in the parts of colorimetry where nonlinear/linear sRGB are being discussed), so I believe it will be less confusing to use the term "linear encoding" than "linear space" when describing how the alpha channel is stored.
Both Aaron and I were uncertain about what encoding was common or expected for the alpha channel of color data, especially because this |
Since we're here, it might be also good to add something like this to the class description:
|
2f55761
to
142f10f
Compare
After thinking more about it, this text might make a problem with the ambiguity of
If this is ever untrue a documentation issue should be opened. Thoughts? (I can make this sort of change a separate PR if you'd prefer.) |
I discussed color spaces and blending with @allenwp in person at GDC and he mentioned these things, which I think should be explicitly stated in the documentation.