Skip to content

Add volume_db to the wav importer #104863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RoyBerardo
Copy link
Contributor

This adds a volume_db setting to the wav importer. Works similarly to normalization where the change is baked into the imported data. Produces a warning if the audio clips when importing.

@RoyBerardo RoyBerardo requested review from a team as code owners March 31, 2025 21:19
@Calinou
Copy link
Member

Calinou commented Mar 31, 2025

Thanks for opening a pull request 🙂

Feature pull requests should be associated to a feature proposal to justify the need for implementing the feature in Godot core. Please open a proposal on the Godot proposals repository (and link to this pull request in the proposal's body).

@fire fire changed the title add volume_db to the wav importer Add volume_db to the wav importer Mar 31, 2025
@RoyBerardo
Copy link
Contributor Author

Ah thank you Calinou! Just created a proposal for this feature. I should mention - the proposal is for all audio file imports, but this PR is specifically for WAVs. I wanted to do this for MP3 and OGG as well, but it's a little more complicated for those.

@RoyBerardo
Copy link
Contributor Author

Converting this to a draft. While looking into doing import volume adjustments for MP3 and OGG, I realized it may be better to give AudioStreams a volume_db property which is applied at playback, and to have the import for MP3/WAV/OGG affect that. I have opened a proposal for this, and will be working on a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants