Skip to content

Add ability to pan audio stream player audio left-right and front/back #104923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rossunger
Copy link

AudioStreamPlayer now has a Vector2 property that controls the panning of the sound which works with stereo and surround.

…ing control, affecting how much of the signal is sent to left/right speaker in stereo mode, or front-left, front-right, rear-left, rear-right in Surround mode
@Calinou
Copy link
Member

Calinou commented Apr 2, 2025

See also a previous implementation of the same feature: #51667

@rossunger
Copy link
Author

See also a previous implementation of the same feature: #51667

Interesting. My pr also supports front-back panning for surround sound, and works with the current AudioStreamPlayer's way of dealing with surround .

It seemed Iike the other pr got closed without merging but from the comments I didnt understand what the outcome was / why.

I think there is a good use case for this to be part of AudioStreamPlayer specifically (not the 2d or 3d one).

If you know of any other place where there was a discussion about why this feature should not exist please let me know (I didn't notice any other links in the other pr you mentioned before). I seem to have mixed luck with finding existing PRs/proposals ..
even though I search the GitHub I've repeatedly missed existing things.

@rossunger
Copy link
Author

Also looking through the source of that other pr I found improvements I need to make to my pr for preserving loudness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants