Convert PtrToArg
macros to regular C++ structs.
#105231
Open
+266
−229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to reduce the number of both macro and template magic throughout Godot. Some of it is pretty convoluted and can be simplified.
As a first step, macros should be converted to regular C++ structs as much as possible.
C style macros are difficult to edit, because they are (until called) not 'regular' code. For example, IDEs struggle to syntax highlight them, or give insights. Therefore, they are undesirable.
For this PR, I simply copy-pasted macro code to named structs. Then, I replaced the macro contents to simply instantiate the requested type with a specialization. Finally, I used my IDE to replace the macros with their contents, to avoid any mistakes with type arguments if I was manually converting.
As a second step, some of these can probably be simplified with C++ template magic in the future. But that's out of scope for this PR.