Add copyright attribution metadata to icon.svg #105358
Draft
+43
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also: #61955 (comment)
TODO
editor/icons/DefaultProjectIcon.svg
, noticon.svg
.<dc:date>2017</dc:date>
is correct or ifCopyright (c) 2017
should be used somewhere.Edit: Was a comment (
<!-- -->
), but now it is SVG metadata.SVG metadata resources:
CI/CD: Possible SVGO bug
SVGO strips the metadata unless both these overrides are present. However, this incorrectly also whitelists editor metadata like
xmlns:inkscape
.A possible workaround is using
scour
or another optimizer.scour --no-line-breaks icon.svg > _icon.svg && mv _icon.svg icon.svg
In the meantime, I enabled pretty print so the diff is easier to view.
svgo icon.svg --config misc/utility/svgo.config.mjs --pretty