Add unit tests for AudioStreamInteractive #105457
Conversation
| @@ -502,6 +502,9 @@ else: | |||
| # Disable assert() for production targets (only used in thirdparty code). | |||
| env.Append(CPPDEFINES=["NDEBUG"]) | |||
|
|
|||
| # adding the line below to remove the error in the control.h file (claimed it could not find core/math) | |||
| env.Append(CPPPATH=['#core']) | |||
There was a problem hiding this comment.
This should be solved differently, this sounds like an issue either in your compilation setup or something related to your tests, this is not the way to fix it
I suspect that you tried to build from inside test/ which is not correct
But regardless of this the fix should be a separate PR if it is needed, this PR shouldn't contain a buildystem fix
There was a problem hiding this comment.
I see, on the writing unit test site it said that the tests would fall under tests/ so I got confused, but I can fix that issue. Thank you for pointing me to a helpful file, and I see the formatting is a little different than those in the tests/ folder. Is the one for jsonrpc the expected unit tests?
There was a problem hiding this comment.
What do you mean for formatting? And what file? Did you mean to reply to my other comment?
There was a problem hiding this comment.
Yeah I meant to reply to your other comment apologies.
|
Contributions to Issue #43440
Basic unit tests to verify the constructor, some getters, and some setters of the AudioStreamInteractive, AudioStreamPlaybackInteractive, AudioStreamSynchronized, and AudioStreamPlaylist class.