Fix identifier #105471
Open
Fix identifier #105471
+24
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed `disable_input` to `input_disabled`, as it's state, not an action. Changed `set_disable_input` to `set_input_disabled` to reflect the change to the identifier.
Changed `disable_input` to `input_disabled`, as it's state, not an action. Changed `set_disable_input` to `set_input_disabled` to reflect the change to the identifier.
Changed `disable_input` to `should_disable_input`, as it's a condition, not an action. Changed `set_disable_input` to `set_input_disabled` to reflect the change to the Input class.
Lexyth
commented
Apr 17, 2025
| bool should_disable_input = scene_tree->is_suspended() || node_select_type != RuntimeNodeSelect::NODE_TYPE_NONE; | ||
| Input::get_singleton()->set_input_disabled(should_disable_input); | ||
| Input::get_singleton()->set_mouse_mode_override_enabled(should_disable_input); | ||
| scene_tree->get_root()->set_disable_input_override(should_disable_input); |
Author
There was a problem hiding this comment.
Fairly certain the name should be changed to set_input_disabled_override, too, but changing anything public about Window seems like a rabbit hole I'd rather avoid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
disable_inputtoinput_disabledin input.h and input.cpp, as it's state, not an action.Changed
set_disable_inputtoset_input_disabledin input.h and input.cpp to reflect the change to the identifier.