Add external custom modules in vcxproj #105517
Open
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelriendeau
commented
Apr 18, 2025
Update methods.py
joelriendeau
force-pushed
the
joel/master
branch
from
687b073 to
f75b10f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds external custom modules to vcxproj generation. Without this, the files are not added to the project and cannot be easily browsed and edited, although they will compile and link correctly.
Because external custom modules use full paths, I also had to strip the ":" character from the exclude patterns, which VS does not support.
I.e. for example without the additional fix you'd get:
<ExcludedFromBuild Condition="!$(ActiveProjectItemList_D:_code_modules_procedural.Contains(...
instead of
<ExcludedFromBuild Condition="!$(ActiveProjectItemList_D_code_modules_procedural.Contains(...