Skip to content

Core: Move math logic to headers where applicable #105685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Apr 23, 2025

This PR aims to migrate applicable math code from source to headers where applicable. That is:

  • Relevant headers are already present
  • Not internal functions that should be obfuscated
  • Functions that would obviously and immediately benefit from inlining

This doubles as a means of guaging header bloat in a constrained environment, and deciding which headers shouldn't be included by default. The most obvious example is the removal of ustring.h includes from several headers, causing a handful of functions to achieve the inverse effect & migrate to their compilation file instead

Goals:

  • Migrate relevant functions from compilation files to header files.
  • Ensuring functions are explicitly inlined through our inlining macros.
  • Reapply inlining macros to constexpr functions during above pass.
  • Integrate constexpr to functions where effortless to do so, keeping with the inlining trend.
  • Trim #include headers to the minimum necessary to function.

@Repiteo Repiteo force-pushed the core/math-to-headers branch from 3346ddf to 327d63e Compare April 23, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant