Never show progress bar when moving files to trash on Windows to prevent losing focus #105788
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Counter argument: deleting even a moderately large file on a slow disk (old HDD or a bad USB) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99552. This also affects the Godot editor itself when deleting files on Windows.
Hides all UI when sending files to the recycle bin on Windows. With the previous flags, we were still requesting a progress bar to be displayed. It typically wouldn't be visible because trashing even large files is often nearly instant (though I could see it when deleting a large directory with many files), but even when not visibly appearing the progress dialog would still momentarily steal focus from the main window.
See https://learn.microsoft.com/en-us/windows/win32/api/shellapi/ns-shellapi-shfileopstructw#fof_no_ui
Based on the implementations for other platforms, I'm assuming that showing a system progress bar is not needed or desired, so changing this in order to avoid the focus steal should be okay.