Skip to content

Fix double translations in Project Manager #105905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timothyqiu
Copy link
Member

Follow-up to #104845

  • Fixed some double translations.
  • Disabled auto translation on some controls. e.g., project path, last modification time, version string.
  • Changed "empty list message" to use the tag stack API instead of BBCode so that it won't be broken by editor pseudolocalization :P
  • Cleaned header includes in files that this PR touched.

Comment on lines +116 to +118
// The bold text above and the regular text below are in the same paragraph, so a space is added.
// This space may be redundant when the text is translated (e.g., into Chinese).
// It is kept as-is since it's hard to find a better solution.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept rereading, but I am still puzzled by this. "[...] are in the same paragraph, so a space is added"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the space between [...] yet. and Get started by [...] is necessary. If Get started by [...] is on its own line, the space is not needed.

demo

Any better wording suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite the unusual case. Given that the BBCode is innocuous and merely stylistic, could the tags not be handled by the localization?
It's not the only place where that's done in the editor, but it's pretty damn uncommon:

  • "[b]Note:[/b] The returned array is [i]copied[/i] [...]" in DocHelp
  • "If [code]true[/code], the tile is horizontally flipped. [...]" & many more in the TileSet editor

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BBCode was changed here because pseudo-localization would break the BBCode code (e.g. [b] could become [ḅ], and in some cases it would dynamically add square brackets, invalidating the syntax).

It is true that pseudo-localization is not intended for end users, but using tag API can be beneficial when debugging the editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants