Support overriding and remapping audio channels in AudioServer #105934
+150
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support (via project settings) to AudioServer to change the number of channels that Godot uses internally, independent of the audio driver used. Also added the ability to remap internal channels onto different output channels of the audio device. This is intended to be used to help troubleshoot audio issues when testing with different speaker setups.
Removed the override flag, changed speaker_mode to allow taking a 'Default' value (to correspond to using the audio driver speaker_mode). Moved the setting to audio/general. Removed the channel remap settings from project settings, and made configuring them done through exposed methods on AudioServer (get/set_channel_remap).
BuzzLord
force-pushed
the
audio-server-override-channels
branch
from
f93e0fa to
de3521e
Compare
|
Updated based on the feedback from the most recent audio team meeting. I left the new commit as is for now (i.e. didn't I also made a little project to help show off the functionality. test-godot-channel-override.zip
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support (via project settings under
audio/buses/channel_override) to theAudioServerto change the speaker mode (i.e. number of channels) that Godot uses internally, independent of the audio driver used. It can be used to test more channels (e.g. 7.1 surround when using a stereo audio setup), or fewer channels (e.g. stereo when using a 7.1 surround setup). This is intended to be used to help troubleshoot audio issues when testing with different speaker setups.This PR also adds the ability to remap internal channels onto different output channels of the audio device. For example, you can remap the rear or side stereo channels of a 7.1 surround system into the front channels of a stereo system in order to verify the audio is correct.
This is a extension of, and replacement for #105682. Like that PR, this feature makes it possible for Godot developers without the necessary surround sound peripheral to reproduce bugs and review fixes to issues that are the result of an unanticipated number of channels, such as: #92532